# HG changeset patch # User Rob Landley # Date 1417217446 21600 # Node ID 1250bc52631617549b7ba189d111cf606049970f # Parent ae2e2fa5fbd1835a6523b7dd990e5ecabc06cc39 Improve error reporting in parallel build. (On error, wait for all children to finish before exiting.) diff -r ae2e2fa5fbd1 -r 1250bc526316 scripts/make.sh --- a/scripts/make.sh Fri Nov 28 16:57:45 2014 -0600 +++ b/scripts/make.sh Fri Nov 28 17:30:46 2014 -0600 @@ -230,6 +230,7 @@ fi PENDING= LFILES= +DONE=0 for i in $FILES do # build each generated/obj/*.o file in parallel @@ -248,18 +249,23 @@ PENDING="$(echo $PENDING $(jobs -rp) | tr ' ' '\n' | sort -u)" [ $(echo -n "$PENDING" | wc -l) -lt "$CPUS" ] && break; - wait $(echo "$PENDING" | head -n 1) || exit 1 + wait $(echo "$PENDING" | head -n 1) + DONE=$(($DONE+$?)) PENDING="$(echo "$PENDING" | tail -n +2)" done + [ $DONE -ne 0 ] && break done # wait for all background jobs, detecting errors for i in $PENDING do - wait $i || exit 1 + wait $i + DONE=$(($DONE+$?)) done +[ $DONE -ne 0 ] && exit 1 + do_loudly $BUILD $LFILES $LINK || exit 1 do_loudly ${CROSS_COMPILE}${STRIP} toybox_unstripped -o toybox || exit 1 # gcc 4.4's strip command is buggy, and doesn't set the executable bit on