Mercurial > hg > toybox
view toys/pending/README @ 1613:96aa7ec74936 draft
Fix yet another sed bug.
The s/// command would copy the \ of substitutions before deciding what to
do with them (generally overwriting the \ with the new data). When the
substitution was A) at the very end of the new string, B) resolved to nothing,
it could leave a trailing \ that didn't belong there and didn't get overwritten
because the "copy trailing data" part that copies the original string's null
terminator already happened before the \ overwrote it.
The ghostwheel() function restarts regexes after embedded NUL bytes, but
if the string it's passed is _longer_ than the length it's told then it
gets confused (and it means we're off the end of our allocation so segfaults
are likely).
Fix: test for \ first and move the "copy byte" logic into an else case.
author | Rob Landley <rob@landley.net> |
---|---|
date | Mon, 15 Dec 2014 03:34:55 -0600 |
parents | f0c4b7476118 |
children | 05c8de3f64fd |
line wrap: on
line source
pending Commands in this directory are external submissions awaiting review and/or cleanup before being "promoted" to one of the other directories. Code in this directory may or may not work, some of the commands here are unfinished stubs, others just need a more thorough inspection than we've had time for yet. Everything in here defaults to "n" in defconfig. Library code awaiting cleanup lives in lib/pending.c The following commands predate the pending directory, and are awaiting cleanup but don't live here: vmstat, login, du, vconfig, mountpoint, chroot, cut, touch, modinfo, expand, xargs lib/password.c