Mercurial > hg > toybox
view toys/other/insmod.c @ 1613:96aa7ec74936 draft
Fix yet another sed bug.
The s/// command would copy the \ of substitutions before deciding what to
do with them (generally overwriting the \ with the new data). When the
substitution was A) at the very end of the new string, B) resolved to nothing,
it could leave a trailing \ that didn't belong there and didn't get overwritten
because the "copy trailing data" part that copies the original string's null
terminator already happened before the \ overwrote it.
The ghostwheel() function restarts regexes after embedded NUL bytes, but
if the string it's passed is _longer_ than the length it's told then it
gets confused (and it means we're off the end of our allocation so segfaults
are likely).
Fix: test for \ first and move the "copy byte" logic into an else case.
author | Rob Landley <rob@landley.net> |
---|---|
date | Mon, 15 Dec 2014 03:34:55 -0600 |
parents | 4bfbd8b96f66 |
children | 57f2a26fa92c |
line wrap: on
line source
/* insmod.c - Load a module into the Linux kernel. * * Copyright 2012 Elie De Brauwer <eliedebrauwer@gmail.com> USE_INSMOD(NEWTOY(insmod, "<1", TOYFLAG_BIN|TOYFLAG_NEEDROOT)) config INSMOD bool "insmod" default y help usage: insmod MODULE [MODULE_OPTIONS] Load the module named MODULE passing options if given. */ #include "toys.h" #include <sys/syscall.h> #define init_module(mod, len, opts) syscall(__NR_init_module, mod, len, opts) void insmod_main(void) { char * buf = NULL; int len, res, i; int fd = xopen(*toys.optargs, O_RDONLY); len = fdlength(fd); buf = xmalloc(len); xreadall(fd, buf, len); i = 1; while(toys.optargs[i] && strlen(toybuf) + strlen(toys.optargs[i]) + 2 < sizeof(toybuf)) { strcat(toybuf, toys.optargs[i++]); strcat(toybuf, " "); } res = init_module(buf, len, toybuf); if (CFG_TOYBOX_FREE) { if (buf != toybuf) free(buf); close(fd); } if (res) perror_exit("failed to load %s", toys.optargs[0]); }