Mercurial > hg > toybox
view toys/lsb/pidof.c @ 1613:96aa7ec74936 draft
Fix yet another sed bug.
The s/// command would copy the \ of substitutions before deciding what to
do with them (generally overwriting the \ with the new data). When the
substitution was A) at the very end of the new string, B) resolved to nothing,
it could leave a trailing \ that didn't belong there and didn't get overwritten
because the "copy trailing data" part that copies the original string's null
terminator already happened before the \ overwrote it.
The ghostwheel() function restarts regexes after embedded NUL bytes, but
if the string it's passed is _longer_ than the length it's told then it
gets confused (and it means we're off the end of our allocation so segfaults
are likely).
Fix: test for \ first and move the "copy byte" logic into an else case.
author | Rob Landley <rob@landley.net> |
---|---|
date | Mon, 15 Dec 2014 03:34:55 -0600 |
parents | 1e4e707fc0bc |
children | 57f2a26fa92c |
line wrap: on
line source
/* pidof.c - Print the Process IDs of all processes with the given names. * * Copyright 2012 Andreas Heck <aheck@gmx.de> * Copyright 2012 Elie De Brauwer <eliedebrauwer@gmail.com> * * http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/pidof.html USE_PIDOF(NEWTOY(pidof, "<1so:", TOYFLAG_USR|TOYFLAG_BIN)) config PIDOF bool "pidof" default y help usage: pidof [-s] [-o omitpid[,omitpid...]] [NAME]... Print the PIDs of all processes with the given names. -s single shot, only return one pid. -o omit PID(s) */ #define FOR_pidof #include "toys.h" GLOBALS( char *omit; ) static int print_pid(pid_t pid, char *name) { char * res; int len; sprintf(toybuf, "%d", (int)pid); len = strlen(toybuf); // Check omit string if (TT.omit && (res = strstr(TT.omit, toybuf))) if ((res == TT.omit || res[-1] == ',') && (res[len] == ',' || !res[len])) return 0; xprintf("%*s", len+(!toys.exitval), toybuf); toys.exitval = 0; return toys.optflags & FLAG_s; } void pidof_main(void) { toys.exitval = 1; names_to_pid(toys.optargs, print_pid); if (!toys.exitval) xputc('\n'); }