Mercurial > hg > toybox
view tests/rev.test @ 1613:96aa7ec74936 draft
Fix yet another sed bug.
The s/// command would copy the \ of substitutions before deciding what to
do with them (generally overwriting the \ with the new data). When the
substitution was A) at the very end of the new string, B) resolved to nothing,
it could leave a trailing \ that didn't belong there and didn't get overwritten
because the "copy trailing data" part that copies the original string's null
terminator already happened before the \ overwrote it.
The ghostwheel() function restarts regexes after embedded NUL bytes, but
if the string it's passed is _longer_ than the length it's told then it
gets confused (and it means we're off the end of our allocation so segfaults
are likely).
Fix: test for \ first and move the "copy byte" logic into an else case.
author | Rob Landley <rob@landley.net> |
---|---|
date | Mon, 15 Dec 2014 03:34:55 -0600 |
parents | 8700cbe1cb29 |
children |
line wrap: on
line source
#!/bin/bash [ -f testing.sh ] && . testing.sh #testing "name" "command" "result" "infile" "stdin" echo -e "one" > file1 echo -e "two" > file2 testing "rev" "rev && echo yes" "orez\nyes\n" "" "zero\n" testing "rev -" "rev - && echo yes" "orez\nyes\n" "" "zero\n" testing "rev file1 file2" "rev file1 file2" "eno\nowt\n" "" "" testing "rev - file" "rev - file1" "orez\neno\n" "" "zero\n" testing "rev file -" "rev file1 -" "eno\norez\n" "" "zero\n" testing "rev no trailing newline" "rev -" "cba\nfed\n" "" "abc\ndef" testing "rev file1 notfound file2" \ "rev file1 notfound file2 2>stderr && echo ok ; cat stderr; rm stderr" \ "eno\nowt\nrev: notfound: No such file or directory\n" "" "" testing "rev different input sizes"\ "rev"\ "\n1\n21\n321\n4321\n54321\n4321\n321\n21\n1\n\n"\ "" "\n1\n12\n123\n1234\n12345\n1234\n123\n12\n1\n\n" rm file1 file2