Mercurial > hg > toybox
view tests/expr.test @ 1613:96aa7ec74936 draft
Fix yet another sed bug.
The s/// command would copy the \ of substitutions before deciding what to
do with them (generally overwriting the \ with the new data). When the
substitution was A) at the very end of the new string, B) resolved to nothing,
it could leave a trailing \ that didn't belong there and didn't get overwritten
because the "copy trailing data" part that copies the original string's null
terminator already happened before the \ overwrote it.
The ghostwheel() function restarts regexes after embedded NUL bytes, but
if the string it's passed is _longer_ than the length it's told then it
gets confused (and it means we're off the end of our allocation so segfaults
are likely).
Fix: test for \ first and move the "copy byte" logic into an else case.
| author | Rob Landley <rob@landley.net> |
|---|---|
| date | Mon, 15 Dec 2014 03:34:55 -0600 |
| parents | d5931155cafe |
| children |
line wrap: on
line source
#!/bin/bash [ -f testing.sh ] && . testing.sh testing "expr integer" "expr 5" "5\n" "" "" testing "expr integer negative" "expr -5" "-5\n" "" "" testing "expr string" "expr astring" "astring\n" "" "" testing "expr 1 + 3" "expr 1 + 3" "4\n" "" "" testing "expr 5 + 6 * 3" "expr 5 + 6 \* 3" "23\n" "" "" testing "expr ( 5 + 6 ) * 3" "expr \( 5 + 6 \) \* 3" "33\n" "" "" testing "expr * / same priority" "expr 4 \* 3 / 2" "6\n" "" "" testing "expr / * same priority" "expr 3 / 2 \* 4" "4\n" "" "" testing "expr & before |" "expr 0 \| 1 \& 0" "0\n" "" "" testing "expr | after &" "expr 1 \| 0 \& 0" "1\n" "" "" testing "expr | & same priority" "expr 0 \& 0 \| 1" "1\n" "" "" testing "expr % * same priority" "expr 3 % 2 \* 4" "4\n" "" "" testing "expr * % same priority" "expr 3 \* 2 % 4" "2\n" "" "" testing "expr = > same priority" "expr 0 = 2 \> 3" "0\n" "" "" testing "expr > = same priority" "expr 3 \> 2 = 1" "1\n" "" "" testing "expr string becomes integer" "expr ab21xx : '[^0-9]*\([0-9]*\)' + 3" \ "24\n" "" ""