view scripts/ @ 1613:96aa7ec74936 draft

Fix yet another sed bug. The s/// command would copy the \ of substitutions before deciding what to do with them (generally overwriting the \ with the new data). When the substitution was A) at the very end of the new string, B) resolved to nothing, it could leave a trailing \ that didn't belong there and didn't get overwritten because the "copy trailing data" part that copies the original string's null terminator already happened before the \ overwrote it. The ghostwheel() function restarts regexes after embedded NUL bytes, but if the string it's passed is _longer_ than the length it's told then it gets confused (and it means we're off the end of our allocation so segfaults are likely). Fix: test for \ first and move the "copy byte" logic into an else case.
author Rob Landley <>
date Mon, 15 Dec 2014 03:34:55 -0600
parents 448e47e2ad46
children 543bee60af4c
line wrap: on
line source


# Build a standalone toybox command

if [ -z "$1" ]
  echo "usage: command..." >&2
  exit 1

for i in "$@"
  NAME=$(echo $i | tr a-z- A-Z_)
  export KCONFIG_CONFIG=.singleconfig
  USET="is not set"

  make allnoconfig > /dev/null &&
  sed -i -e "s/\(CONFIG_TOYBOX\)=y/# \1 $USET/" \
         -e "s/# \(CONFIG_$NAME\) $USET/\1=y/"  \
         -e "s/# \(CONFIG_${NAME}_.*\) $USET/\1=y/" \
         -e "s/# \(CONFIG_TOYBOX_HELP.*\) $USET/\1=y/" \
         -e "s/# \(CONFIG_TOYBOX_I18N\) $USET/\1=y/" \
         -e "s/# \(CONFIG_TOYBOX_FLOAT\) $USET/\1=y/" \
         "$KCONFIG_CONFIG" &&
  make &&
  mv toybox $PREFIX$i || exit 1