Mercurial > hg > toybox
annotate www/cleanup.html @ 1433:00c20f410c46 draft
Patches to commands for issues reported from static analysis tool.
portability.h.patch - it is for O_CLOEXEC, as compiler complained of it.
Makefile.patch - for cleaning generated/*.o files and libopts.dat file
[Fixup to uniq.c from Rob.]
author | Ashwini Sharma <ak.ashwini1981@gmail.com> |
---|---|
date | Tue, 12 Aug 2014 07:09:01 -0500 |
parents | dc254ac8a0e2 |
children |
rev | line source |
---|---|
1180
94eb7b9127d2
Change header and pages so each page has its own title.
Rob Landley <rob@landley.net>
parents:
1178
diff
changeset
|
1 <html><head><title>toybox cleanup</title></head> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
2 <!--#include file="header.html" --> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
3 |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
4 <h1>Index</h1> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
5 |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
6 <ul> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
7 <li><a href=#intro>Introduction</a></li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
8 <li><a href=#advice>Advice</a></li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
9 <li>Commands:</li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
10 <ul> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
11 <li><a href=#uuencode>uuencode</a></li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
12 <li><a href=#uudecode>uudecode</a></li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
13 <li><a href=#ifconfig>ifconfig</a></li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
14 <li><a href=#find>find</a></li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
15 </ul> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
16 </ul> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
17 |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
18 <hr> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
19 |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
20 <a name=intro /> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
21 <h1>Cleaning up the toybox code.</h1> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
22 |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
23 <p>Toybox <a href=http://landley.net/notes.html#31-03-2013>hasn't always</a> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
24 taken proper advantage of external contributions</a>. |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
25 Lots of people want to help, but their contributions languish out of tree |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
26 or in the "pending" directory, awaiting cleanup.</p> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
27 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
28 <p>Toybox's design goals require simpler, tighter, and more explicit code |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
29 than most other implementations, among other reasons to allow better security |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
30 auditing. Writing "another" implementation of standard command line tools |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
31 isn't very interesting, they should be _better_ implementations. |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
32 Unfortunately, this means existing, working commands often take more effort to |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
33 clean up to Toybox's standards than writing a new one from scratch, not |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
34 because they don't work, but because we aim for an unusual level of polish.</p> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
35 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
36 <p>In hopes of teaching more people how to do this |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
37 cleanup work, I've started breaking cleanup changes into smaller chunks and |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
38 posting explanations of each change to the mailing list. |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
39 Below are indexes of such cleanup series. Each commit and post are meant to |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
40 be read together: each description explains what the corresponding patch |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
41 was trying to accomplish.</p> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
42 |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
43 <p>Line/byte totals of completed series are given for scale, but the point |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
44 of this work is simplicity and compactness, not size per se.</p> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
45 |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
46 <p>(Note: mercurial's web viewer doesn't follow renames, so although each |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
47 command name links to a commit list with the bulk of the changes, it may |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
48 not include the final version of each file moved from the "pending" |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
49 directory to its final location. The summaries link the initial and cleaned |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
50 versions of each file when giving line counts.)</p> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
51 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
52 <hr> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
53 |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
54 <a name=advice /> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
55 <h1>General advice and/or policy.</h1> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
56 |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
57 <p>The <a href=design.html>design of toybox</a> page and the coding |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
58 style section at the start of the <a href=code.html>source code walkthrough</a> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
59 don't cover everything. Here are some |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
60 links to mailing list messages that cover various programming topics |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
61 not directly related to a specific cleanup series:</p> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
62 |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
63 <ul> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
64 <li><a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000850.html>Error messages and internationalization.</a></li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
65 <li><a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000891.html>Why not "const"?</a></li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
66 <li><a href=http://lkml.indiana.edu/hypermail/linux/kernel/1308.3/03890.html>Why not "bool"?</a> (explanation from Linus Torvalds)</li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
67 <li><a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000893.html>Why not to check in debug code.</a></li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
68 <li><a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-June/001044.html>Relationship between /proc and /sys</a> (/proc isn't obsolete and /sys is an ABI)</li> |
1402 | 69 <li>"Hiding numbers that are used just once into defines to put them out of |
70 sight does not really help readability."</a> - | |
71 <a href=http://lkml.iu.edu/hypermail/linux/kernel/1407.1/00299.html>Pavel | |
72 Machek</a></li> | |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
73 </ul> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
74 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
75 <hr> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
76 |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
77 <a name="uuencode"><h1><a href=/hg/toybox/log/900/toys/pending/uuencode.c>uuencode</a></h1> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
78 |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
79 <p>This is an example of cleaning up something most projects would be quite |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
80 happy with. The initial submission of uuencode and uudecode was high |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
81 quality code, written by a seasoned developer who did an excellent |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
82 job, but it was still possible to shrink the result almost by half:</p> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
83 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
84 <ul> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
85 <li>old total: <a href=/hg/toybox/file/828/toys/pending/uuencode.c>116 lines (2743 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
86 bytes) in 7 functions</a></li> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
87 <li>new total: <a href=/hg/toybox/file/841/toys/posix/uuencode.c>67 lines (1440 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
88 bytes) in 1 function</a></li> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
89 </ul> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
90 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
91 <ul> |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
92 <li>commit: <a href=/hg/toybox/rev/830>830</a>: first pass, description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000904.html>part 1</a>, |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
93 <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000903.html>part 2</a></li> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
94 <li>commit: <a href=/hg/toybox/rev/831>831</a>, |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
95 second pass, description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000919.html>part 3</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
96 <li>commit: <a href=/hg/toybox/rev/837>837</a>, |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
97 description: fix test suite.</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
98 <li>commit: <a href=/hg/toybox/rev/853>853</a>, description: bugfix.</li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
99 </ul> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
100 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
101 <p>Status: COMPLETE</p> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
102 |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
103 <a name="uudecode"><h1><a href=/hg/toybox/log/900/toys/pending/uudecode.c>uudecode</a></h1> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
104 |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
105 <p>The uudecode cleanup was my second "explain as I go along" cleanup, |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
106 and I tried to do it in smaller stages so it was easier to see what |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
107 changed from the diff:</p> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
108 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
109 <ul> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
110 <li>old: <a href=/hg/toybox/file/828/toys/pending/uudecode.c>175 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
111 lines (4534 bytes) in 9 functions</a></li> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
112 <li>new: <a href=/hg/toybox/file/840/toys/posix/uudecode.c>107 lines |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
113 (2300 bytes) in 1 function</a></li> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
114 </ul> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
115 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
116 <ul> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
117 <li>commit: <a href=/hg/toybox/rev/833>833</a>, |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
118 description: preparatory adjustments to test suite.</li> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
119 <li>commit: <a href=/hg/toybox/rev/835>835</a>, |
1402 | 120 description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2014-January/001532.html>Redo command line parsing, redo parsing loop.</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
121 <li>commit: <a href=/hg/toybox/rev/838>838</a>, |
1402 | 122 description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2014-January/001533.html>Redo b64_1byte, b64_4bytes, and uu_line()</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
123 <li>commit: <a href=/hg/toybox/rev/839>839</a>, |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
124 description: todo</a></li> |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
125 <li>commit: <a href=/hg/toybox/rev/840>840</a>, |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
126 description: todo (finish, move pending->posix, default y)</a></li> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
127 </ul> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
128 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
129 <p>Status: COMPLETE</p> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
130 |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
131 <a name=ifconfig> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
132 <h1><a href=/hg/toybox/log/tip/toys/pending/ifconfig.c>ifconfig</a></h1> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
133 |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
134 <p>This series describes a thorough cleanup that took a while to do.</p> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
135 |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
136 <p>When ifconfig was submitted, it touched a half-dozen files. I glued it |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
137 together into a single self-contained file, which needed a lot of |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
138 cleanup. The final version is about 1/3 the size of the original.</p> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
139 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
140 <ul> |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
141 <li>old total: <a href=/hg/toybox/file/841/toys/pending/ifconfig.c>1504 lines (44268 bytes) in 38 functions</a></li> |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
142 <li>new total: <a href=/hg/toybox/file/1113/toys/other/ifconfig.c>521 lines (15963 bytes) in 4 functions</a></li> |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
143 </ul> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
144 |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
145 <p>This was the first command I started cleaning up with the intent of |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
146 describing the process, and especially the first few entries in this |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
147 series describe many of the low hanging fruit techniques used to clean |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
148 up a codebase.</p> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
149 |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
150 <ul> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
151 <li>commit: <a href=/hg/toybox/rev/843>843</a>, description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000882.html>Infrastructure in search of a user, code proximity, |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
152 unnecessary #defines, shorter code is easier to read.</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
153 <li>commit: <a href=/hg/toybox/rev/844>844</a>, |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
154 description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000881.html>Headers, replacing repeated code with loops, |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
155 logical operators guaranteed to return 0 or 1, math on string constants, |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
156 removing unnecessary variables and tests.</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
157 <li>commit: <a href=/hg/toybox/rev/852>852</a>, |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
158 description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000921.html>hg commit numbers, documenting the obvious, ordering |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
159 to avoid prototypes, returning void, collate local declarations, |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
160 use error_exit(), unnecessary parentheses, inline to remove variables/functions |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
161 used only once, using *var instead of var[0], unnecessary typecasts, |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
162 xprintf("\n") vs xputc('\n')</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
163 <li>commit: <a href=/hg/toybox/rev/856>856</a>, |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
164 description: one line portability fix from Isaac Dunham</li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
165 <li>commit: <a href=/hg/toybox/rev/861>861</a> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
166 and <a href=/hg/toybox/rev/863>863</a>, |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
167 description: |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
168 <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000910.html>Help |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
169 infrastructure cleanup from Isaac Dunham</a> |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
170 (which I mis-applied and then <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000920.html>fixed plus some whitespace changes</a>)</li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
171 |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
172 <li>commit: <a href=/hg/toybox/rev/862>862</a>, description: |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
173 <a href=http://lists.landley.net/pipermail/toybox-landley.net/2014-January/001525.html>remove unused headers and function, replace local buffer with toybuf, perror_exit(), avoid unnecessary assignment.</a></li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
174 <li>commit: <a href=/hg/toybox/rev/864>864</a>, description: |
1365
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
175 <a href=http://lists.landley.net/pipermail/toybox-landley.net/2014-January/001526.html>use common linked list functions, inline set_data, add xioctl, clean up error messages, whitespace and comment tweaks, remove NOP return statements</a></li> |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
176 <li>commit: <a href=/hg/toybox/rev/866>866</a>, description: |
1365
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
177 <a href=http://lists.landley.net/pipermail/toybox-landley.net/2014-January/001528.html>move standalone globals into GLOBALS() block, collate structs into |
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
178 iface_list. Inline/rewrite/remove field_format, iface_flags_str, |
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
179 omit_whitespace(), print_iface_flags(), print_media(), get_ifconfig_info(), |
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
180 and clear_list(). Merge duplicate function |
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
181 calls. Show get_proc_info() version field can't matter in 2.6 or newer kernel, |
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
182 and that SIOCGIFMAP has been there since 1994 so doesn't need an #ifdef. |
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
183 Loop simplification in readconf() and show_iface().</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
184 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
185 <li>commit: <a href=/hg/toybox/rev/869>869</a> and <a href=/hg/toybox/rev/870>870</a>, |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
186 description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000928.html>869: |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
187 reorder to eliminate prototypes, put command_main() at end of file, |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
188 870: long repeated variable prefixes, replacing struct+sscanf()+printf with a |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
189 loop and a table (from iface_list, get_proc_info(), display_ifconfig()), |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
190 use lib/xwrap.c functions to return void, why xstrcpy() fails closed, |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
191 (functional comment: why multicast failed, CSLIP obsolecense), not being |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
192 _too_ clever.</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
193 <li>commit: <a href=/hg/toybox/rev/878>878</a> and <a href=/hg/toybox/rev/879>879</a>: |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
194 description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000946.html>878: add xsocket(), free(NULL) is a safe NOP (posix!). |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
195 879: inline three functions and simplify, some simplifications only show up |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
196 after repeated inlining</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
197 <li>commit: <a href=/hg/toybox/rev/883>883</a>, |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
198 description: move some common code to lib/ and posix headers to toys.h.</li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
199 <li>commit: <a href=/hg/toybox/rev/898>898</a>, |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
200 description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-May/000974.html>Argument parsing. (Replace ifconfig_main() if/else staircase with a loop over |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
201 an array, genericize minus prefix logic, inline a use of set_flags().)</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
202 <li>commit: <a href=/hg/toybox/rev/905>905</a>, |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
203 description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-May/000992.html>remove unnecessary wrapper function, inlining more functions, |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
204 relying on the values of constants that don't change across architectures |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
205 (binary backwards compatability), more ifconfig_main table work, |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
206 man ioctl_list.</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
207 <li>commit: <a href=/hg/toybox/rev/906>906</a>, |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
208 description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-May/000994.html>More ifconfig_main() table work, remove vestigial arguments |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
209 to functions, "a frenzy of inlining", slightly better error reporting, |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
210 don't reinvent libc functions.</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
211 <li>commit: <a href=/hg/toybox/rev/907>907</a>, |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
212 <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-May/000995.html>inlining show_ip_addr() with a loop and a table, inlining hex_to_binary() |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
213 and set_hw_address(), stop validating data we supplied, remove a table |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
214 that's overkill (two entries, we don't even loop over it), when you don't need a |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
215 NULL terminator for array, remove unnecessary memcpy(offsetof()) with |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
216 assignment, trusting -funsigned-char.</a></li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
217 <li>commit: <a href=/hg/toybox/rev/919>919</a>, |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
218 <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-June/001027.html>todo whitespace damage, introduce IFREQ_OFFSZ() and poke() to |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
219 ifconfig_main() table logic to fold more if/else parts into the table</a></li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
220 <li>Status update: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-June/001033.html>Entering the home stretch on ifconfig</a> (and a <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-June/001043.html>note about infiniband</a>)</li> |
1365
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
221 <li>commit: <a href=/hg/toybox/rev/921>921</a>, description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2014-June/003508.html>Inline a couple more functions and make sockfd a global.</li> |
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
222 <li>commit: <a href=/hg/toybox/rev/957>957</a>, description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-July/001121.html>Remove unused socklen and addr_to_len(), cleanup so we can merge get_device_info()/display_ifconfig().</a></li> |
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
223 <li>commit: <a href=/hg/toybox/rev/958>958</a>, description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-July/001131.html>This commit removes struct if_list by unifying get_device_info() and display_ifconfig().</a></li> |
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
224 <li>commit: <a href=/hg/toybox/rev/1104>1104</a>, description: Merge toynet into toys.h: musl supports it and micromanaging uClibc config options isn't very interesting anymore.</li> |
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
225 <li>commit: <a href=/hg/toybox/rev/1127>1127</a>, description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-November/001464.html>Start tacling ipv6 issues, beginning with display_ifconfig().</a></li> |
2320af12ba95
Update cleanup page, now linking to descriptions of all of the ifconfig cleanup.
Rob Landley <rob@landley.net>
parents:
1195
diff
changeset
|
226 <li>commit: <a href=/hg/toybox/rev/1128>1128</a>, description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-November/001463.html>More ipv6, make struct sockaddr_with_len go away, merge more arguments into the table in main().</a></li> |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
227 <li>commit: <a href=/hg/toybox/rev/1132>1132</a>, description: promotion from pending to other</li> |
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
228 <li>commit: <a href=/hg/toybox/rev/1132>1133</a>, description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-November/001462.html>cleanup help text, remove obsolete/NOP commands</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
229 </ul> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
230 |
1178
f8432a8872e0
More work on the cleanup page, partway through describing ifconfig.
Rob Landley <rob@landley.net>
parents:
1056
diff
changeset
|
231 <p>Status: COMPLETE.</p> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
232 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
233 <h1><a href=/hg/toybox/log/tip/toys/pending/find.c>find</a></h1> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
234 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
235 <pre> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
236 814 Initial version by Gurang Shastri. |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
237 815 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
238 816 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
239 847 Felix Janda |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
240 848 Whitespace (reindent from tabs -> 2 spaces) |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
241 849 More cleanup |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
242 867 Felix Janda Improve operator processing. |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
243 874 Felix Janda |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
244 875 Felix Janda |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
245 887 Felix Janda fix -mtime |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
246 </pre> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
247 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
248 <ul> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
249 <li>commit: <a href=/hg/toybox/rev/849>849</a>, |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
250 description: <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000895.html>here</a></li> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
251 </ul> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
252 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
253 <p>Status: in progress.</p> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
254 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
255 <h1><a href=/hg/toybox/log/917/toys/pending/stat.c>stat</a></h1> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
256 |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
257 <p>A lot of the stat cleanup was done by Felix Janda.</p> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
258 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
259 <ul> |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
260 <li>commit <a href=/hg/toybox/rev/747>747</a>: initial submission</a></li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
261 <li>commit <a href=/hg/toybox/rev/810>810</a>: whitespace</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
262 <li>commit <a href=/hg/toybox/rev/811>811</a>: description in commit message.</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
263 <li>commit <a href=/hg/toybox/rev/871>871</a>: whitespace (reindent from 4 spaces to 2)</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
264 <li>commit <a href=/hg/toybox/rev/872>872</a>: Felix Janda - <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000923.html>cleanup</a> (with discussion thread)</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
265 <li>commit <a href=/hg/toybox/rev/875>885</a>: Felix Janda - <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000936.html>move permission formatting (777 -> -rwxrwxrwx) from ls to lib so stat can reuse it.</a></li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
266 <li>commit <a href=/hg/toybox/rev/885>886</a>: Felix Janda - remove unimplemented options and clean up help text</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
267 <li>commit <a href=/hg/toybox/rev/910>910</a>: Felix Janda - <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-May/001013.html>Add support for stating multiple files</a>.</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
268 <li>commit <a href=/hg/toybox/rev/911>911</a>: Felix Janda - Separate stat and statfs, give stat_main() a ds[2] array to distinguish FLAG_f vs not cases, and some whitespace changes.</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
269 <li>commit <a href=/hg/toybox/rev/912>912</a>: description in commit message (also <a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-May/001019.html>here</a>)</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
270 <li><a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-May/001024.html>design pondering</a> (leading to peek() function in lib/)</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
271 |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
272 <li>commit <a href=/hg/toybox/rev/914>914</a>: description in commit message.</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
273 <li>commit <a href=/hg/toybox/rev/916>916</a>: description in commit message.</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
274 <li>commit: <a href=/hg/toybox/rev/917>917</a>: description in commit message.</li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
275 <li>commit: <a href=/hg/toybox/rev/918>918</a>, |
1195
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
276 description: done: move pending to posix, default y, no other changes</a>.</li> |
c4e438cbd37a
More cleanup.html documentation, still way behind...
Rob Landley <rob@landley.net>
parents:
1180
diff
changeset
|
277 <li><a href=http://lists.landley.net/pipermail/toybox-landley.net/2013-June/001026.html>summary</a></li> |
1056
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
278 </ul> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
279 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
280 <p>Status: COMPLETE.</p> |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
281 |
2b35f9c797ad
Pending cleanup page, less than half done. Some of it should probably move to the code style section.
Rob Landley <rob@landley.net>
parents:
diff
changeset
|
282 <!--#include file="footer.html" --> |