BusyBox Bug and Patch Tracking
BusyBox
Main | My View | View Issues | Change Log | Docs
  

Viewing Issue Simple Details [ Jump to Notes ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000991 [BusyBox] Standards Compliance minor always 08-12-06 06:15 09-03-06 07:05
Reporter schieli View Status public  
Assigned To BusyBox
Priority normal Resolution fixed  
Status closed   Product Version 1.2.x
Summary 0000991: tar does not behave like gnu tar when dealing with include/exclude lists
Description There are at least 3 threads about this issue

http://www.busybox.net/lists/busybox/2006-April/020371.html [^]
http://www.busybox.net/lists/busybox/2006-April/020461.html [^]
http://www.busybox.net/lists/busybox/2006-July/023285.html [^]
Additional Information
Attached Files  tar_include_exclude.patch [^] (2,445 bytes) 08-12-06 06:15
 tar_subdirs.patch [^] (3,065 bytes) 09-02-06 14:01

- Relationships

- Notes
(0001603)
vda
09-02-06 12:14

 Please provide testcases where tar does something incorrectly.
So far all issues referenced in links above were addressed by
this patch in svn:

diff -urpN busybox.0/archival/libunarchive/find_list_entry.c busybox.1/archival/libunarchive/find_list_entry.c
--- busybox.0/archival/libunarchive/find_list_entry.c 2006-08-24 11:43:52.000000000 +0200
+++ busybox.1/archival/libunarchive/find_list_entry.c 2006-09-02 20:11:50.000000000 +0200
@@ -13,7 +13,7 @@
 const llist_t *find_list_entry(const llist_t *list, const char *filename)
 {
        while (list) {
- if (fnmatch(list->data, filename, 0) == 0) {
+ if (fnmatch(list->data, filename, FNM_LEADING_DIR) == 0) {
                        return (list);
                }
                list = list->link;


Is this ok?
 
(0001604)
schieli
09-02-06 13:37
edited on: 09-02-06 14:00

 The patch in svn does indeed solve the problems reported in above threads.
Here is a testcase for a remaining one (trailing slash in include list):

mkdir -p foo/bar
touch foo/bar/file
tar cf foo.tar -C foo .
echo "./bar/" > foo.list
rm -rf foo/*
busybox tar xf foo.tar -C foo -T foo.list
find foo | sort >logfile.bb
rm -rf foo/*
tar xf foo.tar -C foo -T foo.list
find foo | sort >logfile.gnu
cmp logfile.gnu logfile.bb

I also updated my patch to take care of this issue.
 
(0001607)
vda
09-03-06 07:05

 Applied
 

- Issue History
Date Modified Username Field Change
08-12-06 06:15 schieli New Issue
08-12-06 06:15 schieli Status new => assigned
08-12-06 06:15 schieli Assigned To  => BusyBox
08-12-06 06:15 schieli File Added: tar_include_exclude.patch
08-12-06 06:19 schieli Issue Monitored: schieli
09-02-06 12:14 vda Note Added: 0001603
09-02-06 13:37 schieli Note Added: 0001604
09-02-06 14:00 schieli Note Edited: 0001604
09-02-06 14:01 schieli File Added: tar_subdirs.patch
09-03-06 07:05 vda Status assigned => closed
09-03-06 07:05 vda Note Added: 0001607
09-03-06 07:05 vda Resolution open => fixed

Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker