Notes |
(0001914)
bernhardf
12-22-06 04:30
|
1) I'd rather prefer if you could expand the host-sed check so we build a working sed for your system.
2) That cp -a patch looks ok. For files, we usually (try to) use "cp -dpf", so please use -dpf resp. -Rdpf
Please attach a new split patch with just the cp changes.
3) I think that the current dependencies.sh should deal with this, please verify.
Thanks in advance for attaching updated, separate patches that take the comments above into account.
cheers,
Bernhard |
| |
(0002559)
bernhardf
07-07-07 11:51
|
To be flexible, i suggest we add
ifeq (linux)
CP_A:=cp -a
endif
ifeq (apple or bsd)
CP_A:=cp ...
endif
variants for "force" "recurse" should be provided. |
| |
(0002589)
chickenandporn
07-11-07 07:36
|
Is there a platform that "cp -fPpR" doesn't work on? Most platforms mimick the old svr4.2r3.2 behavior, or the 4.0r3.0 that migrated from AT&T to BSD, as a bare minimum, right?
I point this out because the following:
xxx: yyyy
cp -fPpR dir1 dir2
...is easier to read than:
xxx: yyyy
$(SOME_BIG_MACRO) dir1 dir2
OK, it might be easier than I am presenting, but if the base behavior is acceptible, and we're used to reading unix commands, it's easier to read if the changes are just made to be the most portable form of commands. |
| |
(0002590)
holin
07-11-07 11:52
edited on: 07-11-07 11:55
|
Try older OS X (10.2), older busybox versions, maybe older BSDs and less common Unix flavors, such as IRIX, HP-UX, and wherever cross-gcc may build. Technically, the POSIX -R is suboptimal substitute to the GNU -d that's used all over to copy symbolic links, but that's about it in the gravely missed features section. Anywhoo, I'd be all for changing to POSIX syntax, too, because that's at least a larger common denominator than GNU. The biggest problem might be that on some platforms, I hear, the POSIX syntax does *something*, but not at all what it's supposed to, i.e. you might get no error, but unwanted results, instead.
|
| |
(0002591)
chickenandporn
07-11-07 12:22
|
I'm not sure if we can test on older 10.2.x MacOSX, nor Atari-520, nor anything else thats below a certain usage unless someone here has one of those.
GNU cp supports cp -R
cp -R causes softlinks to remain exactly, not dereferencing to copy the linked-to file, nor adjusting any relative softlinks.
If there's no argument against it, I'm going to re-cut the patch to turn "cp -a" -type functionality to "cp -PpR", avoiding tar-copying, cpio-copying, and $(CP_A)/$(CP_D)/$(CP_XYZ) notation, with the assumption that someone with an older system that requires a smaller set of options can alter further on another bug. If the next change is incompatible, then we could do a host-coreutils to provide the required compatible commands such as "cp", "mkdir", etc. |
| |
buildroot1.patch [^] (4,566 bytes) 07-12-06 23:48 
