BusyBox Bug and Patch Tracking
BusyBox
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000901 [BusyBox] Other minor always 06-12-06 09:10 06-27-06 16:17
Reporter iggarpe View Status public  
Assigned To BusyBox
Priority normal Resolution fixed  
Status closed   Product Version svn
Summary 0000901: mount -a always reports failure of the last mount (but the mount is done)
Description The error management in mount.c is a bit twisty and definitely wrong in the case of "-a". It will always report that the last mount failed (but it didn't).

See the attached trivial patch. rc is set to zero unconditionally after each successful fstab entry mount, since errors are reported as they happen.

HOWEVER, this solution is also WRONG, since:

1- mount will return 0 (success) even if some auto entry in fstab cannot be mounted.

2- mount will return 1 (error) if there are no auto entries in fstab.

As I said, error management here is just a bit too twisty for me, so I think it's better if whoever wrote mount.c thinks a good way to handle the two cases above.
Additional Information
Attached Files  mount.diff [^] (453 bytes) 06-12-06 09:10

- Relationships

- Notes
(0001466)
landley
06-27-06 16:17

svn 15455 changed mount's error handling behavior. It now returns zero on
success and nonzero on failure.
 

- Issue History
Date Modified Username Field Change
06-12-06 09:10 iggarpe New Issue
06-12-06 09:10 iggarpe Status new => assigned
06-12-06 09:10 iggarpe Assigned To  => BusyBox
06-12-06 09:10 iggarpe File Added: mount.diff
06-27-06 16:17 landley Status assigned => closed
06-27-06 16:17 landley Note Added: 0001466
06-27-06 16:17 landley Resolution open => fixed


Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker