0000085: BusyBox 1,0 ftpput and source file path names

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000085

[BusyBox] New Features

tweak

N/A

02-04-05 11:12

06-24-06 08:15

Reporter

k1mgy

View Status

public

Assigned To

uClibc

Priority

normal

Resolution

fixed

Status

closed

Product Version

Summary

0000085: BusyBox 1,0 ftpput and source file path names

Description

BusyBox ftpput will fail (the server will return an error 553) when the source file specification of an ftpput call is made with a source file name that includes its path. I did a search on this issue and found that some other ftp clients suffer the same malady.

The solution I've built is very simple. Strip the path from the local_path specifier just prior to making the call to ftpcmd("STOR"...

        // place this in the variable definition section
        char cFnBuff[32]; // enough for me

ftpgetput.c approx line 276:

    strcpy(cFnBuff,basename(local_path));
    response = ftpcmd("STOR ", cFnBuff, control_stream, buf);

Therefore, issuing ftpput -u me -p pwd ftp.hostname.com /long/path/to/target /long/path/to/source/file

will now work.

Perhaps this should be patched into frpgetput.c?

Additional Information

Development environment cris.axis.limux.gnu

Attached Files

Relationships

Notes
(0000041) k1mgy 02-04-05 11:15	Sorry, I put this mistakenly in buildroot. It belongs, I think, in BusyBox. However there's no option for me to move it. Would someone with rights to do so please move this to busybox? Thanks!

(0000742) landley 12-07-05 22:19	svn 12184

(0001445) bernhardf 06-24-06 08:14	accidentally set this to resolved when it was already closed. re-closing; sorry for the noise.

Issue History
Date Modified	Username	Field	Change
02-04-05 11:12	k1mgy	New Issue
02-04-05 11:15	k1mgy	Note Added: 0000041
03-16-05 12:14	andersen	Status	new => assigned
03-16-05 12:14	andersen	Assigned To	=> uClibc
03-20-05 18:28	vapier	Project	buildroot => BusyBox
12-07-05 22:19	landley	Status	assigned => closed
12-07-05 22:19	landley	Note Added: 0000742
12-07-05 22:20	landley	Resolution	open => fixed
12-07-05 22:20	landley	Fixed in Version	=> svn
06-23-06 12:38	bernhardf	Status	closed => resolved
06-24-06 08:14	bernhardf	Status	resolved => closed
06-24-06 08:14	bernhardf	Note Added: 0001445