0000788: psmisc no longer builds - BusyBox Bug and Patch Tracking

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000788

[buildroot] Other

minor

always

03-18-06 13:43

02-12-07 05:46

Reporter

likewise

View Status

public

Assigned To

buildroot

Priority

normal

Resolution

fixed

Status

closed

Product Version

Summary

0000788: psmisc no longer builds

Description

The shell scripting in the Makefile for psmisc tries to create signames.h from signames.c through numerous shell commands. That works. The next command does a sanity check for the HUP signal to appear in the resulting signames.h. This grep errors with return code 1 (which invokes rm to remove signames.h again). The Makefile errors out there with 'exit 1':

grep '^{ 1,"HUP" },$$' signames.h >/dev/null || \
{ rm -f signames.h; exit 1; }

In my case, there is no space after the opening accolade '{' in the signames.h file (fix 1).

Even then, grep will not match, only when I remove the $$ (EOL) marker. This might as well be a grep 2.5.1 bug -- please test against other systems.

Additional Information

virgin Ubuntu Dapper Drake (up-to-date 18 March 2006) build host.
grep 2.5.1

Attached Files

Relationships

Notes
(0001187) likewise 03-18-06 13:53	It's the line continuator (\) in the sed command that screws things up (maybe a sed bug then??); it introduces a newline in the signames.h file. --- signames.h: signames.c Makefile /home/leon/sandbox/wrap/buildroot/build_i386/staging_dir/bin/i3$ tr -s '\t ' ' ' \| sort -n -k 3 \| sed \ 's:#define SIG$[A-Z]\+[0-9]$ $[0-9]\+$ $\\|/\.$$$:{\ \2,"\1" },:p;d' \| \ --- Putting it one a single line makes the build work again. GNU sed version 4.1.4

(0001188) vapier 03-19-06 00:52	the $$ is translated by make to just $ when calling grep ive updated the version to 22.8 as it already has this issue fixed

Issue History
Date Modified	Username	Field	Change
03-18-06 13:43	likewise	New Issue
03-18-06 13:43	likewise	Status	new => assigned
03-18-06 13:43	likewise	Assigned To	=> uClibc
03-18-06 13:53	likewise	Note Added: 0001187
03-19-06 00:52	vapier	Note Added: 0001188
03-19-06 00:52	vapier	Status	assigned => closed
03-19-06 00:52	vapier	Resolution	open => fixed
02-12-07 05:46	vapier	Status	closed => assigned
02-12-07 05:46	vapier	Assigned To	uClibc => buildroot