0000076: Defined header CONFIG_FEATURE_DEVPTS from config.h doesn't take effect in telnetd.c

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000076

[BusyBox] Other

major

always

02-02-05 03:13

01-09-06 23:34

Reporter

vijaypadiyar

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.00

Summary

0000076: Defined header CONFIG_FEATURE_DEVPTS from config.h doesn't take effect in telnetd.c

Description

The following section of code in networking/telnetd.c doesn't get implemented even if the header in question (CONFIG_FEATURE_DEVPTS) is defined in config.h:

#ifdef CONFIG_FEATURE_DEVPTS
        p = open("/dev/ptmx", 2);
        if (p > 0) {
                grantpt(p);
                unlockpt(p);
                strcpy(line, ptsname(p));
                return(p);
        }
#else
...

To overcome this, I had to manually include the config.h file from telnetd.c, by adding the following line to the file:

#include <config.h>

Additional Information

Attached Files

telnetd.c [^] (16,414 bytes) 02-02-05 03:13

Relationships

Notes
(0000555) vodz 09-19-05 05:07	No. Its old depend problem and released. Please close this bug.

(0000910) landley 01-09-06 23:34	Fixed a while back by #include "busybox.h" which sucks in config.h

Issue History
Date Modified	Username	Field	Change
02-02-05 03:13	vijaypadiyar	New Issue
02-02-05 03:13	vijaypadiyar	File Added: telnetd.c
03-16-05 12:27	andersen	Assigned To	andersen => BusyBox
09-19-05 05:07	vodz	Note Added: 0000555
01-09-06 23:34	landley	Status	assigned => closed
01-09-06 23:34	landley	Note Added: 0000910
01-09-06 23:34	landley	Resolution	open => fixed