0000739: [PORTABILITY] fuser.c will not compile with pre-C99 compilers

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000739

[BusyBox] Other

major

always

02-19-06 12:11

02-19-06 14:51

Reporter

rfelker

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

unable to reproduce

Status

closed

Product Version

1.01

Summary

0000739: [PORTABILITY] fuser.c will not compile with pre-C99 compilers

Description

In function fuser_kill_pid_list, a statement occurs before mypid is declared. This will fail on most compilers, including odd compilers which may be used in embedded systems and gcc 2.95. The fix is simple; change:

pid_list *curr;
curr = plist;
pid_t mypid = getpid();

to:

pid_list *curr = plist;
pid_t mypid = getpid();

Additional Information

Listed major because it potentially affects setups used by people other than myself. :)

Attached Files

Relationships

Notes
(0001117) vapier 02-19-06 14:51	you're using outdated sources, this has already been fixed in svn a month ago

Issue History
Date Modified	Username	Field	Change
02-19-06 12:11	rfelker	New Issue
02-19-06 12:11	rfelker	Status	new => assigned
02-19-06 12:11	rfelker	Assigned To	=> BusyBox
02-19-06 14:51	vapier	Note Added: 0001117
02-19-06 14:51	vapier	Status	assigned => closed
02-19-06 14:51	vapier	Resolution	open => unable to reproduce