0000694: the uuencode function is repeated in uuencode and wget.

(0001051)
ehovland
02-06-06 13:27

The second patch removes the base64enc function from networking/wget.c and uses the libbb bb_uuencode with a base64 table.

I have not yet figured out how to test this for working in a way that can be put into testsuite. So if anyone has any ideas, add a note.

(0001072)
scott
02-09-06 13:11

Do we need depenency checks in the config for applets 'uuencode' and 'wget' to be sure uuencode is enabled in the libbb? I know buildroot uses deps to be sure required modules are selected.

Or is uuencode always compiled in libbb regardless of the applet config?

(0001073)
ehovland
02-09-06 14:01

The patch as included always builds uuencode into libbb. I am willing to rework the patch so that uuencode doesn't always get built in libbb and then put in the checks in uuencode and wget applets.

Please advise.

(0001282)
bernhardf
04-12-06 12:05

In this case, please provide a single patch in which you rename bb_tbl_base64 to bb_uuenc_tbl_base64 and bb_tbl_std to bb_uuenc_tbl_std.

Also, move your new tests and the old one (uuencode-sets-standard-input-mode-correctly) to the new testing framework (see testsuite/*tests).

TIA

(0001523)
ehovland
07-14-06 16:20

Well, 3 months later. Here is a patch which attempts to do what Bernhard ask for.

I tried to make it conditionally compile uuencode.c in libbb. But I just couldn't figure it out in the time I alloted for this change.

Otherwise, I am hopefully the new patch attached to this issue is good enough.

(0001614)
vda
09-03-06 08:49

Applied to svn

Issue History
Date Modified	Username	Field	Change
02-06-06 13:13	ehovland	New Issue
02-06-06 13:13	ehovland	Status	new => assigned
02-06-06 13:13	ehovland	Assigned To	=> BusyBox
02-06-06 13:13	ehovland	File Added: move_uuencode_to_libbb.patch
02-06-06 13:25	ehovland	File Added: remove_uuencode_from_wget.patch
02-06-06 13:27	ehovland	Note Added: 0001051
02-09-06 13:11	scott	Note Added: 0001072
02-09-06 14:01	ehovland	Note Added: 0001073
04-12-06 12:05	bernhardf	Note Added: 0001282
07-14-06 16:18	ehovland	File Added: bb-uuencode-wget-consolidation.patch
07-14-06 16:20	ehovland	Note Added: 0001523
09-03-06 08:49	vda	Status	assigned => closed
09-03-06 08:49	vda	Note Added: 0001614
09-03-06 08:49	vda	Resolution	open => fixed

Notes
(0001051) ehovland 02-06-06 13:27	The second patch removes the base64enc function from networking/wget.c and uses the libbb bb_uuencode with a base64 table. I have not yet figured out how to test this for working in a way that can be put into testsuite. So if anyone has any ideas, add a note.

(0001072) scott 02-09-06 13:11	Do we need depenency checks in the config for applets 'uuencode' and 'wget' to be sure uuencode is enabled in the libbb? I know buildroot uses deps to be sure required modules are selected. Or is uuencode always compiled in libbb regardless of the applet config?

(0001073) ehovland 02-09-06 14:01	The patch as included always builds uuencode into libbb. I am willing to rework the patch so that uuencode doesn't always get built in libbb and then put in the checks in uuencode and wget applets. Please advise.

(0001282) bernhardf 04-12-06 12:05	In this case, please provide a single patch in which you rename bb_tbl_base64 to bb_uuenc_tbl_base64 and bb_tbl_std to bb_uuenc_tbl_std. Also, move your new tests and the old one (uuencode-sets-standard-input-mode-correctly) to the new testing framework (see testsuite/*tests). TIA

(0001523) ehovland 07-14-06 16:20	Well, 3 months later. Here is a patch which attempts to do what Bernhard ask for. I tried to make it conditionally compile uuencode.c in libbb. But I just couldn't figure it out in the time I alloted for this change. Otherwise, I am hopefully the new patch attached to this issue is good enough.

(0001614) vda 09-03-06 08:49	Applied to svn

Relationships