0000690: [PATCH] lower_bound with last element error

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000690

[uClibc++] Documentation

minor

always

02-06-06 06:15

02-08-06 21:14

Reporter

asierllano

View Status

public

Assigned To

gkajmowi

Priority

normal

Resolution

fixed

Status

resolved

Product Version

Summary

0000690: [PATCH] lower_bound with last element error

Description

An error happened when lower_bound is called with the last error.

I've extended the maptest with the provided patch.
With a patch I've solved the following issues:
- I've solved this bug.
- I've removed the duplicity of ifind and lower_bound being the same thing.
- I've simplified the lower_bound (or ifind) with a simple bisection algorithm that works properly with multimap and map, and that works with zero, one and multiple elements.

Additional Information

Attached Files

uclibcxx-0.1.12-maptest.patch [^] (1,567 bytes) 02-06-06 06:15

uclibcxx-0.1.12-maplowerbound.patch [^] (13,112 bytes) 02-06-06 06:15

Relationships

Notes
(0001050) gkajmowi 02-06-06 12:27	I don't think I'm going to apply this. It's a great fix, and two weeks ago, I would have applied it as it cleans up a lot of things. One problem: I am reimplementing the map code. This is being done because the current map code invalidates iterators upon insert or delete, which violates the spec. There was no clean way to have insert work and not invalidate iterators. Thus I'm re-implementing map and multimap using the classical tree node approach. It's much bulkier, but it's the only clean way I've come across to do this.

(0001069) gkajmowi 02-08-06 21:14	Applied fixes to current SVN. I will change to new version of map once I have verified the code much more. Until then, the current code base is quite good.

Issue History
Date Modified	Username	Field	Change
02-06-06 06:15	asierllano	New Issue
02-06-06 06:15	asierllano	Status	new => assigned
02-06-06 06:15	asierllano	Assigned To	=> gkajmowi
02-06-06 06:15	asierllano	File Added: uclibcxx-0.1.12-maptest.patch
02-06-06 06:15	asierllano	File Added: uclibcxx-0.1.12-maplowerbound.patch
02-06-06 06:15	asierllano	Issue Monitored: asierllano
02-06-06 12:27	gkajmowi	Note Added: 0001050
02-06-06 12:27	gkajmowi	Status	assigned => feedback
02-08-06 21:14	gkajmowi	Status	feedback => resolved
02-08-06 21:14	gkajmowi	Fixed in Version	=> 0.2.0
02-08-06 21:14	gkajmowi	Resolution	open => fixed
02-08-06 21:14	gkajmowi	Note Added: 0001069