0000679: modprobe incrorrectly reads module parametrs from modules.conf

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000679

[BusyBox] Kernel Module Support

crash

always

02-01-06 23:22

06-26-06 14:01

Reporter

vicser

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.01

Summary

0000679: modprobe incrorrectly reads module parametrs from modules.conf

Description

ENABLE_FEATURE_MODPROBE_MULTIPLE_OPTIONS is set

modprobe.c - parse_command_string()
line 238
*dst = xrealloc( *dst, strlen( *dst ) );
should be replaced with the line
*dst = xrealloc( *dst, strlen( *dst ) + 1);

Because when reallocating buffer for the new parameter
the trailing zero (that is set in line 237) is'nt taken into account
This leads to a broken parameter string, that is returned thorugh
the dst parameter.

Additional Information

Attached Files

Relationships

Notes
(0001026) vicser 02-02-06 03:50	More precise definition: This issue concerns to Busybox 1.1.0

(0001027) vodz 02-02-06 06:50	Please test 13797 revision.

(0001455) bernhardf 06-26-06 14:01	Closed by reference of Yann E. MORIN via http://busybox.net/lists/busybox/2006-June/022765.html [^] Please let us know if you still encounter problems.

Issue History
Date Modified	Username	Field	Change
02-01-06 23:22	vicser	New Issue
02-01-06 23:22	vicser	Status	new => assigned
02-01-06 23:22	vicser	Assigned To	=> BusyBox
02-01-06 23:24	vicser	Issue Monitored: vicser
02-02-06 03:50	vicser	Note Added: 0001026
02-02-06 06:50	vodz	Note Added: 0001027
02-02-06 06:50	vodz	Status	assigned => confirmed
02-02-06 06:50	vodz	Resolution	open => fixed
06-26-06 13:05	integrator	Issue Monitored: integrator
06-26-06 14:01	bernhardf	Status	confirmed => closed
06-26-06 14:01	bernhardf	Note Added: 0001455
06-26-06 14:01	bernhardf	Fixed in Version	=> svn