0000651: mdev -s fails to work. - BusyBox Bug and Patch Tracking

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000651

[BusyBox] Other

major

always

01-20-06 00:39

01-22-06 15:14

Reporter

Ken Milmore

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.01

Summary

0000651: mdev -s fails to work.

Description

mdev -s fails consistently with error message of the form:
mknod /dev/hdc failed: Invalid argument

Additional Information

There appear to be two problems in mdev.c:
1. Parsing of dev files in sysfs does not account for the linefeed character, generating bogus device numbers.
2. The find_dev function isn't selecting the correct files in sysfs.
A suggested patch for mdev.c is attached.

Attached Files

mdev.c.patch [^] (724 bytes) 01-20-06 00:39

Relationships

has duplicate	0000793	closed	BusyBox	mdev -s fails with "Illegal argument"
has duplicate	0000805	closed	BusyBox	Unterminated buffer in mdev.c

Notes
(0000974) landley 01-22-06 15:12	The newline thing we fixed in svn 13253, but your fix simplifies the code. The reason for the open coded ascii->int conversion is because this applet is more than usually likely to be statically linked, and thus saving the space taken up by the sscanf() library call is a bonus. Then again, I'm a really big fan of simplicity and this lets us save the loop, variable initialization, and the null terminating step... The missing ! on strcmp() floors me: I tested this and it worked. (Really I did.) Did I check in the wrong version?

(0000975) landley 01-22-06 15:14	svn 13495

Issue History
Date Modified	Username	Field	Change
01-20-06 00:39	Ken Milmore	New Issue
01-20-06 00:39	Ken Milmore	Status	new => assigned
01-20-06 00:39	Ken Milmore	Assigned To	=> BusyBox
01-20-06 00:39	Ken Milmore	File Added: mdev.c.patch
01-22-06 15:12	landley	Note Added: 0000974
01-22-06 15:14	landley	Status	assigned => closed
01-22-06 15:14	landley	Note Added: 0000975
01-22-06 15:14	landley	Resolution	open => fixed
04-11-06 11:02	bernhardf	Relationship added	has duplicate 0000793
04-11-06 11:03	bernhardf	Relationship added	has duplicate 0000805