0000614: ftput: fail to submit local_path if local_path do not refer to a local file

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000614

[BusyBox] Standards Compliance

minor

always

12-27-05 00:49

06-23-06 12:40

Reporter

robang74

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.01

Summary

0000614: ftput: fail to submit local_path if local_path do not refer to a local file

Description

Mark Richards wrote:

> Quite some time ago I fixed/changed ftpgetput.c so that ftpput will work
> from a directory other than the source file.
>
> ie:
> ftpput -u name -p pass 192.191.91.6 /var/root/2
> /var/tmp/upload/etc.tar.gz
>
> will fail with:
>
> ftpput: STOR error: /var/tmp/upload/etc.tar.gz: No such file or
> directory
>
> ...if the command is not executed in /var/tmp/upload.
>

Additional Information

I wrote a patch starting from Mark's one which fixes also

- ftpput help/info now use remote-directory instead remote-file which
are confusing because rename file during upload is not possible.

- a typo in a function name

*** ATTENTION TO 2nd PATCH, about ftpget ****

I would change ftpget argument order from

ftpput remote-host local-file remote-file

to

ftpput remote-host remote-file local-file

but it would broke shell scripts compatibility with previous version.
So I left this change in a different patch, if you apply it please care to inform the users.

Attached Files

ftpgetput.diff [^] (1,829 bytes) 12-27-05 00:57

ftpget-dangerous_ui_change.diff [^] (1,111 bytes) 12-27-05 01:09

ftpgetput_typos.patch [^] (729 bytes) 01-31-06 05:30

Relationships

Notes
(0000816) robang74 12-27-05 00:54	before patch: ./busybox ftpput -u ** -p * ftp.roberto.foglietta.name www.roberto.foglietta.name/tmp _install/bin/busybox ftpput: _install/bin/busybox: No such file or directory echo $? 1 after patch: ./busybox ftpput -u -p *** ftp.roberto.foglietta.name www.roberto.foglietta.name/tmp _install/bin/busybox echo $? 0

(0000822) robang74 12-28-05 03:38	I suspect this report is a duplicate of http://bugs.busybox.net/view.php?id=85 [^] and it has been fixed in SVN, sorry.

(0001023) robang74 01-31-06 05:30	First patch does not apply cleanly anymore in SVN, so I think it will be the same for the 2nd. However I am not sure these patches are usefull anymore. Third patch is a cosmetic one that fix a typo in a function name

(0001444) bernhardf 06-23-06 12:39	Should be fixed in svn. Reopen or file a new one if you still encounter problems.

Issue History
Date Modified	Username	Field	Change
12-27-05 00:49	robang74	New Issue
12-27-05 00:49	robang74	Status	new => assigned
12-27-05 00:49	robang74	Assigned To	=> BusyBox
12-27-05 00:50	robang74	Issue Monitored: robang74
12-27-05 00:54	robang74	Note Added: 0000816
12-27-05 00:57	robang74	File Added: ftpgetput.diff
12-27-05 01:09	robang74	File Added: ftpget-dangerous_ui_change.diff
12-28-05 03:38	robang74	Note Added: 0000822
01-31-06 05:27	robang74	Issue End Monitor: robang74
01-31-06 05:27	robang74	Issue Monitored: robang74
01-31-06 05:30	robang74	File Added: ftpgetput_typos.patch
01-31-06 05:30	robang74	Note Added: 0001023
06-23-06 12:39	bernhardf	Status	assigned => closed
06-23-06 12:39	bernhardf	Note Added: 0001444
06-23-06 12:40	bernhardf	Resolution	open => fixed
06-23-06 12:40	bernhardf	Fixed in Version	=> 1.2.x