BusyBox Bug and Patch Tracking
BusyBox
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000607 [BusyBox] Other major always 12-19-05 09:42 01-09-06 21:31
Reporter iggarpe View Status public  
Assigned To BusyBox
Priority normal Resolution fixed  
Status closed   Product Version
Summary 0000607: mount -a will only correctly mount the first non noauto filesystem in /etc/fstab
Description The title says it all. If in 0000606 the non initialization of f for each fstab entry iteration caused a crash, here, the non initialization of rc causes premature exit.

See attached patch, which also fixes 0000606 in a better way.

Also, the if/else at the end of the fstab iteration loop is wrong, and if not using mtab, will always run as if there had been an error. Fixed too in the attached patch.

Also, the final error message is misplaced, because:

1- If cleanup is enabled, it will be using blockDevice, directory, etc which have already been deallocated.

2- In the "all" case, will show the blockDevice, directory, etc values at the end of the loop, which will not be right unless the error happened at the very last line of /etc/fstab. Fixed in the attached patch.



Additional Information
Attached Files  mount.diff [^] (414 bytes) 12-19-05 09:42

- Relationships

- Notes
(0000898)
landley
01-09-06 21:11

I'm confused, the patch in 607 and the patch in 606 look the same to me. What "better way"?

If this patch fixes both, let me know. (Mount -a still doesn't mix with -o properly, and remount is still generally horked, but I'll fix that eventually...)
 
(0000899)
landley
01-09-06 21:31

svn 13216
 

- Issue History
Date Modified Username Field Change
12-19-05 09:42 iggarpe New Issue
12-19-05 09:42 iggarpe Status new => assigned
12-19-05 09:42 iggarpe Assigned To  => BusyBox
12-19-05 09:42 iggarpe File Added: mount.diff
01-09-06 21:11 landley Note Added: 0000898
01-09-06 21:31 landley Status assigned => closed
01-09-06 21:31 landley Note Added: 0000899
01-09-06 21:31 landley Resolution open => fixed
01-10-06 02:09 robang74 Issue Monitored: robang74


Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker