0000601: tar -zcvf blocks forever - BusyBox Bug and Patch Tracking

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000601

[BusyBox] Other

major

always

12-15-05 09:13

12-16-05 13:34

Reporter

iggarpe

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

svn

Summary

0000601: tar -zcvf blocks forever

Description

Try:

tar -zcvf dummy.tar.gz /bin/busybox

Never exits. Seems that the job is done and the dummy.tar.gz file is correct.

This bug was introduced in revision 11876, and I traced the change responsible. It seems that the close() call (see patch) is needed for correct termination, or maybe this change just exposed some other bug.

Whatever: the attached patch fixes the problem, but someone should review it and try to understand why it works!!!.

Additional Information

Attached Files

tar.diff [^] (515 bytes) 12-15-05 09:15

busybox.config [^] (12,910 bytes) 12-16-05 04:00

Relationships

Notes
(0000788) landley 12-16-05 00:07	A) I'm simply not seeing this. You didn't tell us your kernel version, C library, architecture, and so on. B) There is no way that change should POSSIBLY have that symptom. Something is very wrong with your environment. I don't know if it's your compiler, your kernel, your C library, or what. But this fix ain't it.

(0000790) iggarpe 12-16-05 03:55	I'm running Fedora Core 4, kernel 2.6.14. To reproduce this bug, you MUST have "cleanup" disabled. The attached fix just moves the close() call out of the if (ENABLE_FEATURE_CLEANUP), so it is always executed. I attach my .config file. This is what I do to reproduce the bug: ./busybox tar -zcvf dummy.tar.gz busybox

(0000791) landley 12-16-05 13:34	Ah. The fd is a pipe to a child process, and if we don't close it then the child won't exit, thus waitpid() is hanging. Gotcha. svn 12941

Issue History
Date Modified	Username	Field	Change
12-15-05 09:14	iggarpe	New Issue
12-15-05 09:14	iggarpe	Status	new => assigned
12-15-05 09:14	iggarpe	Assigned To	=> BusyBox
12-15-05 09:16	iggarpe	File Added: tar.diff
12-16-05 00:07	landley	Note Added: 0000788
12-16-05 00:07	landley	Status	assigned => feedback
12-16-05 03:55	iggarpe	Note Added: 0000790
12-16-05 04:00	iggarpe	File Added: busybox.config
12-16-05 13:34	landley	Status	feedback => closed
12-16-05 13:34	landley	Note Added: 0000791
12-16-05 13:34	landley	Resolution	open => fixed
12-16-05 13:34	landley	Fixed in Version	=> svn