| Anonymous | Login | Signup for a new account | 11-10-2008 10:38 PST |
| Main | My View | View Issues | Change Log | Docs |
| Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||||
| ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||
| 0000006 | [BusyBox] Other | minor | always | 01-13-05 05:02 | 07-18-05 15:26 | ||||
| Reporter | Tito | View Status | public | ||||||
| Assigned To | BusyBox | ||||||||
| Priority | normal | Resolution | fixed | ||||||
| Status | closed | Product Version | 1.00 | ||||||
| Summary | 0000006: [PATCH] devfsd wrong error messages patch | ||||||||
| Description |
The devfsd patch applies on CVS and should fix the problem reported by Allen Chan about wrong error messages displayed sometimes due to bad errno checking by taking into account Bastian Blank's suggestions: > It is a bug itself to relay on the value of errno after > something else than the original call. |
||||||||
| Additional Information |
I tested it in many situations: with /dev/log without /dev/log with OPTIONAL_INCLUDE file_that_exists with OPTIONAL_INCLUDE file_that_exists_but_is_zero_size with OPTIONAL_INCLUDE file_that_not_exists with OPTIONAL_INCLUDE dir_that_not_exists with OPTIONAL_INCLUDE dir_that_exists_but_is_empty and it seems to me that it reports errors correctly or at least in a simlar way as the original devfsd. BTW there is also a little reduction in size: root@localhost:/dev/pts/4:/root/Desktop/busybox/miscutils# size devfsd.o text data bss dec hex filename 10176 392 543 11111 2b67 devfsd.o root@localhost:/dev/pts/4:/root/Desktop/busybox/miscutils# size devfsd.o.orig text data bss dec hex filename 10236 392 543 11171 2ba3 devfsd.o.orig There are also some indentation fixes. |
||||||||
| Attached Files |
|
||||||||
|
|
|||||||||
Notes |
|
|
(0000233) Tito 06-06-05 23:06 |
Cleaned up patch applied |
|
(0000293) pgf 07-16-05 14:55 |
committed as svn 10480 |
| Copyright © 2000 - 2006 Mantis Group |