0005324: spurious output from modprobe - BusyBox Bug and Patch Tracking

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0005324

[BusyBox] Other

minor

always

10-09-08 01:45

10-10-08 05:41

Reporter

vapier

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

open

Status

assigned

Product Version

Summary

0005324: spurious output from modprobe

Description

if you run `modprobe` on a system that lacks /etc/modprobe.d, you get spurious warnings now:
root:/> modprobe fat
modprobe: /etc/modprobe.d: No such file or directory
root:/> modprobe -r fat
modprobe: /etc/modprobe.d: No such file or directory

Additional Information

not sure what the best fix is here ... add a new flag to recursive_action() to silence missing dirs ? update modutils.c to not run include_conf_recursive() if the dir does not exist ?

-if (include_conf_recursive(&conf, "/etc/modprobe.d"))
+if (!access("/etc/modprobe.d", X_OK) && include_conf_recursive(&conf, "/etc/modprobe.d"))

Attached Files

Relationships

Notes
(0013174) vda 10-10-08 05:41	Doesn't happen on 1.13.x (svn). ACTION_QUIET suppresses it here: static int read_config(struct modprobe_conf conf, const char path) { return recursive_action(path, ACTION_RECURSE \| ACTION_QUIET, config_file_action, NULL, conf, 1); } modprobe.c doesn't have include_conf_recursive after some recent patches. The easiest solution is to create /etc/modprobe.d and just wait for next upgrade cycle. Or create a stopgap patch for 1.12.x... hmmm... ok: http://busybox.net/downloads/fixes-1.12.1/busybox-1.12.1-modprobe.patch [^] Does it work for you?

Issue History
Date Modified	Username	Field	Change
10-09-08 01:45	vapier	New Issue
10-09-08 01:45	vapier	Status	new => assigned
10-09-08 01:45	vapier	Assigned To	=> BusyBox
10-10-08 05:41	vda	Note Added: 0013174