0000428: Extra space character (0x20) is added to last string option

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000428

[BusyBox] Kernel Module Support

major

always

09-13-05 10:55

12-18-05 11:56

Reporter

mareksk

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.00

Summary

0000428: Extra space character (0x20) is added to last string option

Description

Extra space character (0x20) is always being added to the last option passed to insmod. In case of the last option is a string value, this value is expanded by one character. For instance, if the last option is arg=1234, the string passed to a module is "1234 ".

The code below points a part of 'mod_insert' function, where a simple fix could be added

for ( i = 0; i < argc; i++ ) {
  strcat ( head-> m_options, argv [i] );
  /* this prevents from adding an extra 0x20 after the last option */
  if( (i+1) < argc ) {
    strcat ( head-> m_options, " " );
  }
}

Additional Information

Attached Files

Relationships

Notes
(0000691) integrator 11-23-05 14:22	It broke in rev. 11043. Before, the shell would have parsed the options, and removed the trailing space. It's no longer the case, because we don't use a shell. As a first quick fix, enable multiple options parsing.

(0000797) landley 12-18-05 11:56	svn 12922

Issue History
Date Modified	Username	Field	Change
09-13-05 10:55	mareksk	New Issue
09-13-05 10:55	mareksk	Status	new => assigned
09-13-05 10:55	mareksk	Assigned To	=> BusyBox
11-23-05 14:22	integrator	Note Added: 0000691
12-18-05 11:56	landley	Status	assigned => closed
12-18-05 11:56	landley	Note Added: 0000797
12-18-05 11:56	landley	Resolution	open => fixed
12-18-05 11:56	landley	Fixed in Version	=> svn