BusyBox Bug and Patch Tracking
BusyBox
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000424 [BusyBox] Standards Compliance minor always 09-09-05 09:47 11-03-05 17:56
Reporter ingo View Status public  
Assigned To BusyBox
Priority normal Resolution fixed  
Status closed   Product Version svn
Summary 0000424: cp don't bothers about full filesystem. cat forces file buffering.
Description I found two small bugs, which had both s.th. todo with the rewrite of the file libbb/copyfd.c

cp: if the destination filesystem is full, it just exits without a proper error code or error message.

cat: i noticed this error, when I was testing if my mouse was probably recognized. "cat /proc/psaux" gave me simply no output. What I know now is that it only buffers this output for at least 4096 Bytes. But I didn't move my mouse so long ;)
Additional Information "cat" should operate by character, like it always did. This got lost with the switch from 'safe_read' to 'bb_full_read' in copyfd.c. I personally don't understand this change.

"cp" get's no error from bb_copyfd_eof, which get's none from the same function, producing the problems above: bb_full_fd_action
Everything works fine, and at the end of this function, there is a
  if (status == 0 || total) return total;

Without this '|| total', which makes no sense to me, it would fail just fine. ;)

I'm in progress, doing a workaround for myself, and only wanted to here some voices of people who know busybox a bit better than me ;)
Attached Files  copyfd.patch [^] (1,331 bytes) 09-12-05 01:13

- Relationships

- Notes
(0000513)
ingo
09-12-05 01:12

I've created a small patch, which now works for me.
Some feedback would be nice...

regards, ingo


(I'll upload it in a second ;)
 
(0000517)
morpheusz
09-14-05 00:33

The same bug was reported by me same weeks ago, the bug is http://bugs.busybox.net/view.php?id=394 [^]
 
(0000518)
ingo
09-14-05 01:26

Sorry, didn't notice your PR.
But at least it seams that we had similar approaches for solving this problem ;)
 
(0000655)
landley
11-03-05 17:56

The cp part was a duplicate of bug 493 (fixed by svn 12146). The cat part
was just fixed by svn 12147.
 

- Issue History
Date Modified Username Field Change
09-09-05 09:47 ingo New Issue
09-09-05 09:47 ingo Status new => assigned
09-09-05 09:47 ingo Assigned To  => BusyBox
09-12-05 01:12 ingo Note Added: 0000513
09-12-05 01:13 ingo File Added: copyfd.patch
09-12-05 06:23 ingo Issue Monitored: ingo
09-14-05 00:33 morpheusz Note Added: 0000517
09-14-05 01:26 ingo Note Added: 0000518
11-03-05 17:56 landley Note Added: 0000655
11-03-05 17:56 landley Status assigned => closed
11-03-05 17:56 landley Resolution open => fixed
11-03-05 17:56 landley version 1.00 => svn


Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker