Anonymous | Login | Signup for a new account | 11-10-2008 12:30 PST |
Main | My View | View Issues | Change Log | Docs |
Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||||
ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||
0004164 | [buildroot] Shared Library Support | minor | always | 07-16-08 08:31 | 08-16-08 12:18 | ||||
Reporter | artemys | View Status | public | ||||||
Assigned To | buildroot | ||||||||
Priority | normal | Resolution | fixed | ||||||
Status | closed | Product Version | |||||||
Summary | 0004164: SDL_ttf needs SDL to be compiled first | ||||||||
Description |
It is possible to select the build of SDL_ttf even if SDL is not selected. -> compilation error Correction patch attached. Same should apply to SDL_mixer... |
||||||||
Additional Information | Correct bad "SDL" target in sdl_ttf.mk too. | ||||||||
Attached Files |
sdl_ttf-depends-on-sdl.patch [^] (856 bytes) 07-16-08 08:31 sdl_ttf-depends-on-sdl_v2.patch [^] (913 bytes) 07-17-08 01:28 |
||||||||
|
Relationships | ||||||
|
Notes | |
(0009404) bernhardf 07-16-08 08:47 |
--- package/sdl_ttf/Config.in.org 2008-07-16 17:10:29.000000000 +0200 +++ package/sdl_ttf/Config.in 2008-07-16 17:10:57.000000000 +0200 @@ -1,6 +1,7 @@ config BR2_PACKAGE_SDL_TTF bool "SDL_TTF" default n + depends on BR2_PACKAGE_SDL yes, exactly. select BR2_PACKAGE_FREETYPE help SDL_ttf is a sample TrueType font library. It allows you to --- package/sdl_ttf/sdl_ttf.mk.org 2008-07-16 17:29:42.000000000 +0200 +++ package/sdl_ttf/sdl_ttf.mk 2008-07-16 17:30:06.000000000 +0200 @@ -60,7 +60,7 @@ cp -dpf $(STAGING_DIR)/usr/lib/libSDL_ttf*.so* $(TARGET_DIR)/usr/lib/ -$(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/lib/libSDL_ttf.so -SDL sdl_ttf: uclibc $(TARGET_DIR)/usr/lib/libSDL_ttf.so +SDL_TTF sdl_ttf: uclibc $(TARGET_DIR)/usr/lib/libSDL_ttf.so That caps "SDL_TTF" sounds wrong (or at least redundant). Also, i suspect that you will need to have libsdl.so as prereq, something like: sdl_ttf: uclibc $(TARGET_DIR)/usr/lib/libSDL.so \ $(TARGET_DIR)/usr/lib/libSDL_ttf.so |
(0009414) artemys 07-16-08 10:24 |
sdl_ttf: uclibc sdl $(TARGET_DIR)/usr/lib/libSDL_ttf.so will also work, I think... |
(0009524) artemys 07-17-08 00:20 |
If I try to compile SDL_ttf with SDL not already selected, then I have the same problem as issue http://busybox.net/bugs/view.php?id=2174 [^] |
(0009534) bernhardf 07-17-08 00:59 |
That's why "depends on BR2_PACKAGE_SDL" is the correct thing to do, yes (and i stated it was correct). Please attach a complete, tested patch so somebody can apply it to svn. TIA and cheers, Bernhard |
(0009554) artemys 07-17-08 01:29 |
New patch added (sdl_ttf-depends-on-sdl_v2.patch) |
(0009594) jacmet 07-17-08 02:51 |
Thanks, committed. |
(0009604) bernhardf 07-17-08 03:37 |
If an issue is fixed then the convention is to set it to "closed". |
(0009614) bernhardf 07-17-08 03:38 |
So, if this is fixed then it should be closed as in "closed". TIA |
Copyright © 2000 - 2006 Mantis Group |