Notes |
(0000435)
vapier
08-25-05 22:49
|
umm, there has never been a configure.ac in busybox, so i dont know busybox version your patch is against |
| |
(0000439)
rmh
08-27-05 03:05
|
Sorry, I assumed the Debian packaged version of busybox was similar enough.
I'm attaching a fixed patch. I've adapted it for current SVN and verified that it still works. |
| |
(0000442)
vapier
08-27-05 11:22
|
ive committed the libbb/syscalls.c and procps/top.c and procps/uptime.c changes ... please note that our syntax rules use tabs for indenting, not spaces
the Makefile refactoring i dont really like ... i think this is something we need to think through and design -> start a thread on the busybox mailing list
also, all the ugly ifdef's for linux/bsd/whatever is something we dont want either ... this falls under the rewrite landley has been tossing around lately to hide all the ugly os/libc details in a single header file |
| |
(0000443)
rmh
08-27-05 14:29
|
> ive committed the libbb/syscalls.c and procps/top.c and procps/uptime.c changes ... please note that our syntax rules use tabs for indenting, not spaces
Sorry about that, I'll be more careful (my editor has an horrid tendency to break tabs into spaces silently).
> the Makefile refactoring i dont really like ... i think this is something we need to think through and design -> start a thread on the busybox mailing list
Ok.
> also, all the ugly ifdef's for linux/bsd/whatever is something we dont want either ... this falls under the rewrite landley has been tossing around lately to hide all the ugly os/libc details in a single header file
What about the sysdeps/gnu-kfreebsd/ dir? Is this ok for committing? |
| |
(0000444)
vapier
08-27-05 22:50
|
no, a lot of the stuff looks like it will be duplicated between the linux and gnu-freebsd subdirs so the smart thing would be to unify the common options ... but again, this is something to be tossed around on the mailing list |
| |
(0004234)
vda
02-12-08 02:45
|
Old. Patches are most probably need to be heavily updated. |
| |