0003914: busybox unzip overwrite existing files - BusyBox Bug and Patch Tracking

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003914

[BusyBox] Other

minor

always

06-29-08 06:58

06-29-08 07:15

Reporter

prien

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.2.x

Summary

0003914: busybox unzip overwrite existing files

Description

when i execute busybox unzip -o myfile.zip, I want to decompress new myfile to overwrite existing old myfile,but it produces unexpected results. If the size of the new file(myfile) is smalller than the old one, it cannot completely override the old file, and I got the wrong file.

I look for the source code in archival/unzip.c and find 369 line:

369 dst_fd = bb_xopen(dst_fn, O_WRONLY | O_CREAT);

I change it with:

369 dst_fd = bb_xopen(dst_fn, O_WRONLY | O_CREAT | O_TRUNC);

so busybox unzip -o myfile.zip can work right

Additional Information

Attached Files

Relationships

Notes
(0008834) vda 06-29-08 07:15	This bug was fixed 1.5 years ago. Try newer version.

Issue History
Date Modified	Username	Field	Change
06-29-08 06:58	prien	New Issue
06-29-08 06:58	prien	Status	new => assigned
06-29-08 06:58	prien	Assigned To	=> BusyBox
06-29-08 07:15	vda	Status	assigned => closed
06-29-08 07:15	vda	Note Added: 0008834
06-29-08 07:15	vda	Resolution	open => fixed