BusyBox Bug and Patch Tracking
BusyBox
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0003254 [uClibc] Shared Library Support major always 05-06-08 12:29 06-02-08 16:47
Reporter frabar666 View Status public  
Assigned To uClibc
Priority normal Resolution fixed  
Status closed   Product Version
Summary 0003254: Build: dlfcn.h removed when it shouldn't be
Description Product version: svn-HEAD

svn-r20475 added logic to rm <dlfcn.h> during build (in "Makefile.in") and remove its inclusion (in "include/link.h") when "not supporting" shared libraries. However the two conditionals are not the same: the first one tests "!HAVE_SHARED", while the second one tests "HAVE_NO_SHARED".
The problem is that "HAVE_NO_SHARED" is not always "!HAVE_SHARED" (AFAIK first one is auto-detected from ARCH, whereas second one is a user config choice if "!HAVE_NO_SHARED"). In this case:
- HAVE_NO_SHARED is not defined (ARCH supports shared libs),
- HAVE_SHARED is not defined (user doesn't want shared lib support),
<dlfcn.h> is rm'd by "Makefile.in", yet is still included by "include/link.h", which obviously doesn't compile.
(problem seen when using buildroot with uClibc-snapshot, during compilation of gcc's crtbegin*.o and crtend*.o -- I can provide more info (arch, versions, config, ...) if needed)

I'm not sure which one of the two conditions is the right one, but I'd go with "HAVE_NO_SHARED"? That's what the attached patch does, it fixed the problem in my case.
Additional Information
Attached Files  uClibc-dlfcn.patch [^] (500 bytes) 05-06-08 12:29

- Relationships

- Notes
(0007964)
vda
06-02-08 16:47

Fixed in rev 22193, thanks.
 

- Issue History
Date Modified Username Field Change
05-06-08 12:29 frabar666 New Issue
05-06-08 12:29 frabar666 Status new => assigned
05-06-08 12:29 frabar666 Assigned To  => uClibc
05-06-08 12:29 frabar666 File Added: uClibc-dlfcn.patch
06-02-08 16:47 vda Status assigned => closed
06-02-08 16:47 vda Note Added: 0007964
06-02-08 16:47 vda Resolution open => fixed


Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker