0003164: m68k build fails with the default ARCH_CFLAGS setting, gcc 4.3, and binutils 2.18

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003164

[uClibc] Architecture Specific

minor

always

04-27-08 01:25

09-29-08 07:35

Reporter

kendallc

View Status

public

Assigned To

uClibc

Priority

normal

Resolution

fixed

Status

closed

Product Version

Summary

0003164: m68k build fails with the default ARCH_CFLAGS setting, gcc 4.3, and binutils 2.18

Description

The default ARCH_CFLAGS setting in extra/Configs/Config.m68k is "-Wa,--bitwise-or". The build fails because gcc outputs an assembly comment with "|", but "-Wa,--bitwise-or" tells binutils not to treat "|" as a comment.

For a long time, GCC for m68k has defined ASM_COMMENT_START as "|". Before binutils 2.17, the meaning of the flag was "Permit `|' to be used in expressions." I think that setting the flag didn't hurt anything because "|" was treated as a comment even if the flag was set. In binutls 2.17, the flag changed to mean "do not treat `|' as a comment character". Now, the flag breaks compilation because gcc outputs "|" to start a comment, and the assembler doesn't accept it.

It's easy enough for users to change the config, but it's pretty difficult to figure out why uClibc doesn't build by default. I don't think "-Wa,--bitwise-or" has much benefit, and now it breaks the build, so I think it might be good to remove "-Wa,--bitwise-or" as the default setting.

Additional Information

Attached Files

Relationships

Notes
(0012454) bernhardf 09-29-08 07:35	Fixed in r23557. Thanks!

Issue History
Date Modified	Username	Field	Change
04-27-08 01:25	kendallc	New Issue
04-27-08 01:25	kendallc	Status	new => assigned
04-27-08 01:25	kendallc	Assigned To	=> uClibc
09-29-08 07:35	bernhardf	Status	assigned => closed
09-29-08 07:35	bernhardf	Note Added: 0012454
09-29-08 07:35	bernhardf	Resolution	open => fixed
09-29-08 07:35	bernhardf	Fixed in Version	=> 0.9.30