0000282: The mount atime and diratime options set all the mount flags

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000282

[BusyBox] Other

major

always

06-03-05 00:47

01-09-06 18:38

Reporter

jbowler

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.00

Summary

0000282: The mount atime and diratime options set all the mount flags

Description

If mount -o atime or mount -o diratime is used the mount proceeds with all the mount flags (such as noexec etc) set.

This is because of the following lines from mount.c in the mount_options structure initialisation:

{"atime", , ~MS_NOATIME},
{"diratime", , ~MS_NODIRATIME},

They should be {foo, ~foo, 0} - the arguments are {name, and, or}, and does nothing, or ~MS_NOATIME sets everything except MS_NOATIME.

Additional Information

/dev/foo / auto atime 0 0

in /etc/fstab has a particularly amusing interaction with the common "mount -o remount,$options /" frequently found in the startup script to fsck / - / ends up noexec.

Attached Files

Relationships

Notes
(0000734) landley 12-07-05 20:17	I believe the mount rewrite fixed this. Could you try to reproduce with 1.1-pre1 or current svn? Rob

(0000894) landley 01-09-06 18:38	svn 13215

Issue History
Date Modified	Username	Field	Change
06-03-05 00:47	jbowler	New Issue
12-07-05 20:17	landley	Note Added: 0000734
12-07-05 20:17	landley	Status	assigned => feedback
01-09-06 18:38	landley	Status	feedback => closed
01-09-06 18:38	landley	Note Added: 0000894
01-09-06 18:38	landley	Resolution	open => fixed
01-09-06 18:38	landley	Fixed in Version	=> svn