0000281: mount -at <type> mounts all the file systems, not just those of type <type>

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000281

[BusyBox] Other

major

always

06-03-05 00:39

02-18-08 04:59

Reporter

jbowler

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.00

Summary

0000281: mount -at <type> mounts all the file systems, not just those of type <type>

Description

mount -a -t nfs

(and the like) is used within standard init scripts to mount only nfs file systems in fstab. Busybox mount accepts these options but ignores the -t nfs and mounts everything. This is bad because it remounts stuff like tmpfs partitions, obscuring any boot time setup already done in them.

Additional Information

The fix requires recognition of a somewhat extended set of 'type' options - the argument can be a list with an optional 'no' prefix to invert the test. The attached patch implements the fix. Notice that the semantics of 'no' are poorly defined - the behaviour of this patch matches the documentation of a recent mount version on Gentoo Linux as well as the actual use in a real shell script (which use does not correspond to the documentation, fortunately it just uses an undefined syntax...)

Attached Files

mount-all-type.patch [^] (2,199 bytes) 06-03-05 00:39

Relationships

Notes
(0001013) jbowler 01-26-06 16:06	I think this still exists in 1.1.0 (by code examination), but the code has changed substantially so the patch won't apply.

(0001590) bernhardf 08-25-06 08:50	Can you please retry this, either with the current 1.2.1-release or with trunk? If it still fails, please ping Mr. landley via the lists. thanks,

(0005024) vda 02-18-08 04:59	Doesn't happen with current svn: # ./mount -vv -n -f -a mount: would do mount('/dev/sda5','/','ext3',0x00008401,'(null)') mount: would do mount('/dev/sda6','/.share','reiserfs',0x00008400,'(null)') mount: would do mount('/dev/sda7','/.1','reiserfs',0x00008400,'(null)') mount: would do mount('/dev/sda8','/.2','reiserfs',0x00008400,'(null)') # ./mount -vv -n -f -a -t nfs [no output] # _

Issue History
Date Modified	Username	Field	Change
06-03-05 00:39	jbowler	New Issue
06-03-05 00:39	jbowler	File Added: mount-all-type.patch
01-10-06 02:08	robang74	Issue Monitored: robang74
01-26-06 16:06	jbowler	Note Added: 0001013
08-25-06 08:50	bernhardf	Note Added: 0001590
02-18-08 04:59	vda	Status	assigned => closed
02-18-08 04:59	vda	Note Added: 0005024
02-18-08 04:59	vda	Resolution	open => fixed