0000251: broadcast address isn't recalculated if ifconfig of a network address with a non-standard netmask

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000251

[BusyBox] Networking Support

minor

always

05-09-05 04:13

11-23-06 05:23

Reporter

perh

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.00

Summary

0000251: broadcast address isn't recalculated if ifconfig of a network address with a non-standard netmask

Description

There exist today an option CONFIG_FEATURE_IFCONFIG_BROADCAST_PLUS which
enables one to add a ifconfig argument like "broadcast +" which will automatically
calculate broadcast address correctly.
If one don't add the broadcast address, it will be calculated by kernel
code in the ioctl of SIOCSIFBRDADDR. In the case the user sets a non-standard
netmask, it will be calculated incorrectly (because the netmask isn't known
at the time and standard netmask according to IP is used...)
The patch calculate and sets broadcast after setting netmask (but not
if broadcast has already been set -> we don't want to overwrite a already
specified broadcast) and thus this little nag is history :-)

Additional Information

Attached Files

busybox-1.00.patch [^] (765 bytes) 05-09-05 04:13

Relationships

Notes
(0001793) vda 11-23-06 05:23	It looks like it is working correctly in current svn. However iyt is hard to check for that - bug reports does not contain an example of what is not working right exactly.

Issue History
Date Modified	Username	Field	Change
05-09-05 04:13	perh	New Issue
05-09-05 04:13	perh	File Added: busybox-1.00.patch
11-23-06 05:23	vda	Status	assigned => closed
11-23-06 05:23	vda	Note Added: 0001793
11-23-06 05:23	vda	Resolution	open => fixed
11-23-06 05:23	vda	Fixed in Version	=> 1.2.x