convert. E.g. "5000`" will be converted to 50009. Looking at the code I see that
this is a corner case that is not checked:
...
digit = (((Wuchar)(*str - '0')) <= 9)
? (*str - '0')
: ((*str >= 'A')
? (((0x20|(*str)) - 'a' + 10)) /* WARNING: assumes ascii. */
: 40);
if (digit >= base) {
break;
}
...
A backtick is 0x60. So it is greater than 'A'. 0x20|0x60 is 0x80. 0x80-'a'+10
evaluates to '9' which is accepted as a valid digit. This piece of code occurs
more than once in the code. The trunk seems to contain the bug, too.
The solution would be to explicitly check for this case.
strtol.patch [^] (607 bytes) 11-07-07 04:36 
