Anonymous | Login | Signup for a new account | 11-10-2008 11:21 PST |
Main | My View | View Issues | Change Log | Docs |
Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||||
ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||
0001571 | [buildroot] Architecture Specific | minor | always | 11-04-07 03:13 | 11-27-07 13:41 | ||||
Reporter | ikonst | View Status | public | ||||||
Assigned To | buildroot | ||||||||
Priority | normal | Resolution | fixed | ||||||
Status | closed | Product Version | |||||||
Summary | 0001571: AVR32 patch in libmad causes unnecessary config.status --recheck | ||||||||
Description |
Since the libmad-0.15.1b-avr32-optimization.patch modifies both 'configure.ac' and 'configure', a timing issue will often occur. Within every standard Makefile, there's a rule which causes a rebuild of the configure file (by means of running autoconf) when 'configure.ac' is newer than 'configure'. Within libmad-0.15.1b-avr32-optimization.patch, configure.ac is patched AFTER configure, and so, the 'configure.ac' may end up being newer. Worse yet, this happens "randomly": if both files are patches in the same second, the problem isn't visible. The attached patch reorders configure.ac to appear BEFORE configure within libmad-0.15.1b-avr32-optimization.patch. |
||||||||
Additional Information |
1) This problem can also be "solved" by prefixing the $(MAKE) command with TARGET_CONFIGURE_ARGS, so that ./config-status --recheck runs within the same environment as the original ./configure, but my fix also eliminates the time wasted on the unnecessary "recheck". 2) This patch eliminates the need for Ulf's patch in revision 20353. |
||||||||
Attached Files | libmad-avr32-optimization-reorder.patch [^] (5,058 bytes) 11-04-07 03:13 | ||||||||
|
Copyright © 2000 - 2006 Mantis Group |