BusyBox Bug and Patch Tracking
BusyBox
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0001545 [buildroot] Other minor always 10-20-07 21:27 10-21-07 05:03
Reporter marcg View Status public  
Assigned To buildroot
Priority normal Resolution fixed  
Status closed   Product Version 0.9.27
Summary 0001545: lsof package configures using host instead of target includes
Description The lsof package uses its own Configure system, which requires LSOF_INCLUDE to point to the target's include directory. Without this it defaults to looking at /usr/include to decide on configuration parameters. Encountered this where the target didn't have selinux/selinux.h in its headers, yet lsof's Configure enabled selinux anyway when it found /usr/include/selinux/selinux.h on the host.

Here's a generic patch that fixes this.

Index: package/lsof/lsof.mk
===================================================================
--- package/lsof/lsof.mk (revision 8)
+++ package/lsof/lsof.mk (working copy)
@@ -10,6 +10,7 @@
 LSOF_DIR:=$(BUILD_DIR)/lsof_$(LSOF_VERSION)
 LSOF_BINARY:=lsof
 LSOF_TARGET_BINARY:=bin/lsof
+LSOF_INCLUDE:=$(STAGING_DIR)/usr/include
 
 BR2_LSOF_CFLAGS:=
 ifeq ($(BR2_LARGEFILE),)
@@ -33,7 +34,7 @@
        touch $(LSOF_DIR)/.unpacked
 
 $(LSOF_DIR)/.configured: $(LSOF_DIR)/.unpacked
- (cd $(LSOF_DIR)/lsof_$(LSOF_VERSION)_src; echo n | $(TARGET_CONFIGURE_OPTS) DEBUG="$(TARGET_CFLAGS) $(BR2_LSOF_CFLAGS)" ./Configure linux)
+ (cd $(LSOF_DIR)/lsof_$(LSOF_VERSION)_src; echo n | $(TARGET_CONFIGURE_OPTS) DEBUG="$(TARGET_CFLAGS) $(BR2_LSOF_CFLAGS)" LSOF_INCLUDE="$(LSOF_INCLUDE)" ./Configure linux)
        touch $(LSOF_DIR)/.configured
 
 $(LSOF_DIR)/lsof_$(LSOF_VERSION)_src/$(LSOF_BINARY): $(LSOF_DIR)/.configured
Additional Information
Attached Files

- Relationships

- Notes
(0002853)
vanokuten
10-21-07 05:03

patch applied in svn r20310, thanks
 

- Issue History
Date Modified Username Field Change
10-20-07 21:27 marcg New Issue
10-20-07 21:27 marcg Status new => assigned
10-20-07 21:27 marcg Assigned To  => buildroot
10-21-07 05:03 vanokuten Status assigned => closed
10-21-07 05:03 vanokuten Note Added: 0002853
10-21-07 05:03 vanokuten Resolution open => fixed


Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker