0001508: wget don't support DLNA enabled HTTP servers (and their special headers)

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001508

[BusyBox] Standards Compliance

minor

always

09-24-07 05:43

09-24-07 06:52

Reporter

sloeuillet

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

svn

Summary

0001508: wget don't support DLNA enabled HTTP servers (and their special headers)

Description

In the middle of classic HTTP headers that any web server would send, a DLNA server would send this special header :
transfermode.dlna.org: Interactive

Yes, you see well, those are dots.

Looking at wget.c source code, more specifically gethdr() method, we could see :
http://busybox.net/cgi-bin/viewcvs.cgi/trunk/busybox/networking/wget.c?rev=19557&view=markup [^]

    /* convert the header name to lower case */
    for (s = buf; isalnum(*s) || *s == '-'; ++s)
        *s = tolower(*s);

    /* verify we are at the end of the header name */
    if (*s != ':')
        bb_error_msg_and_die("bad header line: %s", buf);

As you see, it would go to the second test once the first '.' is encountered, and would display the message.

Of course, it would fail to download the file

It works ok with the standard wget utility.
As DLNA is a standard protocol on top of HTTP, we could suppose this is standard.

Could you please fix it to allow dots too ?

Additional Information

HTTP/1.1 RFC :
http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2 [^]

Attached Files

Relationships

Notes
(0002787) sloeuillet 09-24-07 06:13	Patch against 1.01 but looking at the code, it didn't change much since then and should apply smoothly

(0002788) vda 09-24-07 06:52	Fixed in svn. Thanks.

Issue History
Date Modified	Username	Field	Change
09-24-07 05:43	sloeuillet	New Issue
09-24-07 05:43	sloeuillet	Status	new => assigned
09-24-07 05:43	sloeuillet	Assigned To	=> BusyBox
09-24-07 06:13	sloeuillet	Note Added: 0002787
09-24-07 06:52	vda	Status	assigned => closed
09-24-07 06:52	vda	Note Added: 0002788
09-24-07 06:52	vda	Resolution	open => fixed