BusyBox Bug and Patch Tracking
BusyBox
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0001465 [buildroot] Architecture Specific major always 08-15-07 01:54 09-19-07 07:11
Reporter vogelchr View Status public  
Assigned To buildroot
Priority normal Resolution fixed  
Status closed   Product Version 0.9.27
Summary 0001465: installing dropbear does not check for etc/init.d/ directory
Description When installing dropbear the install makefile just copies the init-script to etc/init.d without making sure that etc/init.d is a existing directory:

cp -dpf /home/chris/buildroot/build_i586/dropbear-0.50/S50dropbear /home/chris/buildroot/project_build_i586//root/etc/init.d/
cp: target `/home/chris/buildroot/project_build_i586//root/etc/init.d/' is not a directory: No such file or directory
make: *** [/home/chris/buildroot/project_build_i586//root/usr/sbin/dropbear] Error 1

The proposed fix makes the install go through...
Additional Information in package/dropbear/dropbear.mk:

$(TARGET_DIR)/$(DROPBEAR_TARGET_BINARY): $(DROPBEAR_DIR)/$(DROPBEAR_BINARY)
        # ... left out few lines ...
        cp -dpf $(DROPBEAR_DIR)/S50dropbear $(TARGET_DIR)/etc/init.d/
        chmod a+x $(TARGET_DIR)/etc/init.d/S50dropbear

atrocity buildroot $ svn info package/dropbear/dropbear.mk
Path: package/dropbear/dropbear.mk
Name: dropbear.mk
URL: svn://uclibc.org/trunk/buildroot/package/dropbear/dropbear.mk [^]
Repository Root: svn://uclibc.org [^]
Repository UUID: 69ca8d6d-28ef-0310-b511-8ec308f3f277
Revision: 19510
Node Kind: file
Schedule: normal
Last Changed Author: ulf
Last Changed Rev: 19433
Last Changed Date: 2007-08-11 20:43:58 +0200 (Sat, 11 Aug 2007)
Text Last Updated: 2007-08-15 10:04:35 +0200 (Wed, 15 Aug 2007)
Checksum: 9b6faec48d922f96251abee84b14adca

Proposed fix:
--- package/dropbear/dropbear.mk (revision 19510)
+++ package/dropbear/dropbear.mk (working copy)
@@ -56,6 +56,7 @@
     ln -snf ../sbin/dropbear $(TARGET_DIR)/usr/bin/dbclient
     ln -snf ../sbin/dropbear $(TARGET_DIR)/usr/bin/dropbearkey
     ln -snf ../sbin/dropbear $(TARGET_DIR)/usr/bin/dropbearconvert
+ [ -d $(TARGET_DIR)/etc/init.d ] || mkdir -p $(TARGET_DIR)/etc/init.d
     cp -dpf $(DROPBEAR_DIR)/S50dropbear $(TARGET_DIR)/etc/init.d/
     chmod a+x $(TARGET_DIR)/etc/init.d/S50dropbear
 

Attached Files

- Relationships

- Notes
(0002757)
bernhardf
09-19-07 07:11

Fixed in r19892.
Thanks!
 

- Issue History
Date Modified Username Field Change
08-15-07 01:54 vogelchr New Issue
08-15-07 01:54 vogelchr Status new => assigned
08-15-07 01:54 vogelchr Assigned To  => buildroot
09-19-07 07:11 bernhardf Status assigned => closed
09-19-07 07:11 bernhardf Note Added: 0002757
09-19-07 07:11 bernhardf Resolution open => fixed


Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker