0001431: [patch] new applet: netmsg - BusyBox Bug and Patch Tracking

(0002612)
vda
07-21-07 07:06

1. You can use netcat for that, we have that in bbox.

2. It's easier to discuss patches on the mailing list.

3. Review:

+ while (strlen(argv[2]) > 0) {

argv[2][0] != 0

+ memset(buf, 0, sizeof (buf));
+
+ buf[0] = 0xde;
+ buf[1] = 0xad;
+ strlcpy(buf + 2, argv[2], sizeof (buf) - 2);

Use strncpy, it will do memset for you.

+ argv[2] += strlen(buf + 2);

In effect you scan argv[2] byte-by-byte twice here.

+
+ if (setsockopt(s, SOL_SOCKET, SO_BROADCAST,
+ (caddr_t)&optval, sizeof (optval)) < 0) {
+ perror("setsockopt()");

bb_perror_msg_and_die()

(0002632)
mirabilos
07-23-07 03:36

Feel free to change the things you found, I don't object,
and the original author seems to want this in upstream too.

(0004604)
vda
02-14-08 04:07

Sorry, but closing without applying. This is not a reimplementation of standard or well-known utility, it's just a quickly (and not very cleanly) written UDP sender. We can use netcat for sending UDPs.

Issue History
Date Modified	Username	Field	Change
07-20-07 05:00	mirabilos	New Issue
07-20-07 05:00	mirabilos	Status	new => assigned
07-20-07 05:00	mirabilos	Assigned To	=> BusyBox
07-20-07 05:00	mirabilos	File Added: 300-netmsg.patch
07-21-07 07:06	vda	Note Added: 0002612
07-23-07 03:36	mirabilos	Note Added: 0002632
02-14-08 04:07	vda	Status	assigned => closed
02-14-08 04:07	vda	Note Added: 0004604
02-14-08 04:07	vda	Resolution	open => no change required

Notes
(0002612) vda 07-21-07 07:06	1. You can use netcat for that, we have that in bbox. 2. It's easier to discuss patches on the mailing list. 3. Review: + while (strlen(argv[2]) > 0) { argv[2][0] != 0 + memset(buf, 0, sizeof (buf)); + + buf[0] = 0xde; + buf[1] = 0xad; + strlcpy(buf + 2, argv[2], sizeof (buf) - 2); Use strncpy, it will do memset for you. + argv[2] += strlen(buf + 2); In effect you scan argv[2] byte-by-byte twice here. + + if (setsockopt(s, SOL_SOCKET, SO_BROADCAST, + (caddr_t)&optval, sizeof (optval)) < 0) { + perror("setsockopt()"); bb_perror_msg_and_die()

(0002632) mirabilos 07-23-07 03:36	Feel free to change the things you found, I don't object, and the original author seems to want this in upstream too.

(0004604) vda 02-14-08 04:07	Sorry, but closing without applying. This is not a reimplementation of standard or well-known utility, it's just a quickly (and not very cleanly) written UDP sender. We can use netcat for sending UDPs.

Relationships