With this patch it scans /lib/modules even without old kernel compatibility
999-insmod2.6_search.patch [^] (5,287 bytes) 05-11-07 07:25 insmod.diff [^] (5,327 bytes) 05-20-07 11:27 
| Anonymous | Login | Signup for a new account | 11-10-2008 11:15 PST |
| Main | My View | View Issues | Change Log | Docs |
| Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||||
| ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||
| 0001344 | [BusyBox] Kernel Module Support | tweak | always | 05-11-07 07:25 | 05-25-07 13:18 | ||||
| Reporter | ralf | View Status | public | ||||||
| Assigned To | integrator | ||||||||
| Priority | normal | Resolution | won't fix | ||||||
| Status | closed | Product Version | 1.4.x | ||||||
| Summary | 0001344: let insmod scan /lib/modules even wothout 2.2 and 2.4 kernel support | ||||||||
| Description |
Busybox insmod looks in /lib/modules to find the right module only if support for older kernels is enabled in config. With this patch it scans /lib/modules even without old kernel compatibility |
||||||||
| Additional Information | |||||||||
| Attached Files |
999-insmod2.6_search.patch [^] (5,287 bytes) 05-11-07 07:25 insmod.diff [^] (5,327 bytes) 05-20-07 11:27 |
||||||||
|
|
|||||||||
 Relationships |
|
|
Notes |
|
|
(0002366) integrator 05-17-07 08:56 |
ralf, What are you trying to achieve here? |
|
(0002385) ralf 05-20-07 10:00 |
integrator: let insmod scan /lib/modules even when 2.4 modules support wasn't compiled in |
|
(0002388) integrator 05-20-07 10:55 |
ralf, What I was asking is why you need to scan those directories in the first place? I believe it's not the responsibility of insmod to search where the module is, but modprobe's. Currently modprobe does quite a good job at that, and shall be used. I also believe that module searching should be yanked out of insmod (if there is any). The real insmod from outter world does no search at all. Instead of "insmod foobar.ko", just type "modprobe foobar". Or supply the full path to the module with "insmod /lib/module/version/kernel/some/dir/foobar.ko" |
|
(0002389) ralf 05-20-07 11:27 |
the new patch applies against current SVN |
|
(0002390) integrator 05-20-07 12:10 |
Ralf, First of, we must decide wether its the job of insmod or not. Again, plain insmod from module-init-tools does NOT search for modules. Do we want to add this feature that the original code doesn't have? I guess no. Second, you're mostly duplicating code in your patch. Common code should lie in a function that gets called from everywhere it's needed. If we decide to incorporate this code, you'll have to refactor your patch. Ralf, are you subsribed to the BB mailing list? If so, we should switch there to see what people think about this issue. Regards, Yann E. MORIN (aka integrator). |
|
(0002402) integrator 05-25-07 13:18 |
As Bernhard Fischer states, which Mike Frysinger and I second: "No. If you want a module loader that searches for mods, there's modprobe." Yann E. MORIN. |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 05-11-07 07:25 | ralf | New Issue | |
| 05-11-07 07:25 | ralf | Status | new => assigned |
| 05-11-07 07:25 | ralf | Assigned To | => BusyBox |
| 05-11-07 07:25 | ralf | File Added: 999-insmod2.6_search.patch | |
| 05-11-07 07:25 | ralf | Issue Monitored: ralf | |
| 05-17-07 08:55 | integrator | Assigned To | BusyBox => integrator |
| 05-17-07 08:56 | integrator | Note Added: 0002366 | |
| 05-17-07 08:56 | integrator | Issue Monitored: integrator | |
| 05-20-07 10:00 | ralf | Note Added: 0002385 | |
| 05-20-07 10:55 | integrator | Note Added: 0002388 | |
| 05-20-07 11:27 | ralf | File Added: insmod.diff | |
| 05-20-07 11:27 | ralf | Note Added: 0002389 | |
| 05-20-07 12:10 | integrator | Note Added: 0002390 | |
| 05-25-07 13:18 | integrator | Status | assigned => closed |
| 05-25-07 13:18 | integrator | Note Added: 0002402 | |
| 05-25-07 13:18 | integrator | Resolution | open => won't fix |
| Copyright © 2000 - 2006 Mantis Group |  |
