0001318: Patch of applet.c for busybox outputting help message by itself

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001318

[BusyBox] Other

minor

always

04-18-07 03:36

04-18-07 14:00

Reporter

rockeychu

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

svn

Summary

0001318: Patch of applet.c for busybox outputting help message by itself

Description

Since SVN 18436, running "busybox" or "./busybox" doesn't show help message anymore. The reason is: when argv[1] is NULL, argv[2] is just a illegal address.

Patch as following:

Index: applets/applets.c
===================================================================
--- applets/applets.c (revision 18484)
+++ applets/applets.c (working copy)
@@ -547,7 +547,7 @@
        /* Deal with --help. Also print help when called with no arguments */

        if (!argv[1] || !strcmp(argv[1], "--help") ) {
- if (argv[2]) {
+ if (argv[1] && argv[2]) {
                        /* set name for proper "<name>: applet not found" */
                        applet_name = argv[2];
                        argv[2] = NULL;

Additional Information

Attached Files

Relationships

Notes
(0002326) vda 04-18-07 14:00	Fixed in rev 18491, thanks!

Issue History
Date Modified	Username	Field	Change
04-18-07 03:36	rockeychu	New Issue
04-18-07 03:36	rockeychu	Status	new => assigned
04-18-07 03:36	rockeychu	Assigned To	=> BusyBox
04-18-07 14:00	vda	Status	assigned => closed
04-18-07 14:00	vda	Note Added: 0002326
04-18-07 14:00	vda	Resolution	open => fixed