0001317: ether-wake will send broadcasts if not told so

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001317

[BusyBox] Networking Support

trivial

always

04-16-07 14:57

04-16-07 16:17

Reporter

firetwister

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

Summary

0001317: ether-wake will send broadcasts if not told so

Description

ether-wake will send broadcasts if any flag is specified. It should only send broadcasts if -b is supplied.

At line 125 the flags get parsed

flags = getopt32(argc, argv, "bi:p:", &ifname, &pass);

At line 141 the return value of getopt32 will get assigned to 'get_fill', which will set the broadcast address if flags != 0.

pktsize = get_fill(outpack, &eaddr, flags /*& 1 [OPT_BROADCAST]*/);

Simply move the '/*' 3 characters to the right and it works ;-)

This bug seems to be very old, at least the oldest and the latest version in svn are affected.

Additional Information

Attached Files

Relationships

Notes
(0002323) vda 04-16-07 16:16	Fixed in rev 18463, thanks!

Issue History
Date Modified	Username	Field	Change
04-16-07 14:57	firetwister	New Issue
04-16-07 14:57	firetwister	Status	new => assigned
04-16-07 14:57	firetwister	Assigned To	=> BusyBox
04-16-07 16:16	vda	Status	assigned => closed
04-16-07 16:16	vda	Note Added: 0002323
04-16-07 16:17	vda	Resolution	open => fixed