0001267: Rev ision 18018, ifstate warning printed with first time boot

Notes
(0002224) vda 03-09-07 13:08	Replace fopen_or_warn with plain fopen. Is this looks ok to you?

(0002225) espakman 03-09-07 13:41	That works, but I'm not sure what the desired behavior should be. In Debian the statefile is cleaned/recreated at every boot with an init.d script. The patch (rev 18018) to read the previous statefile can be tricky, what happens if no ifdown -a is done at reboot or halt time? The state is kept and after booting (and no clean of the statefile with an init script) ifup -a will think the interfaces are up. Or am I wrong?

(0002226) vda 03-09-07 13:49	I think /var/run is supposed to be cleaned up on each boot. It contains pidfiles and similar information, not permanent data. As for the idea of keeping info in such a file in general, well... I find the whole idea (design) of ifup/ifdown fragile, and therefore I personally don't use it. Thus cannot vouch on the correctness of that change in rev 18018.

(0002227) espakman 03-09-07 14:04	Agree. I just checked, in Debian the statefile is placed in /etc/network/run/ instead of /var/run/. So that should be the reason why it's explicitly cleaned there. I think the correct fix is not to warn if the file doesn't exist so "fopen" instead of "fopen_or_warn".

(0002228) vda 03-09-07 14:48	Fixed in rev 18059. Thanks!

Relationships