0001226: static busybox break tftp - BusyBox Bug and Patch Tracking

Notes
(0002177) vda 02-17-07 08:10	I think your build produced the following warning: #warning Static linking against glibc produces buggy executables #warning (glibc does not cope well with ld --gc-sections). #warning See sources.redhat.com/bugzilla/show_bug.cgi?id=3400 #warning Note that glibc is unsuitable for static linking anyway. #warning If you still want to do it, remove -Wl,--gc-sections #warning from top-level Makefile and remove this warning. Did you try non-static build? Did you remove -Wl,--gc-sections? Please show those tcpdumps you mention. Also there were some fixes to tftp recently, consider testing current svn.

(0002181) goutnet 02-19-07 07:46	I did remove the mentionned code, applying a selfmade patch : Index: busybox/Makefile =================================================================== --- busybox.orig/Makefile 2007-02-15 16:42:26.000000000 +0100 +++ busybox/Makefile 2007-02-15 16:42:29.000000000 +0100 @@ -563,7 +563,7 @@ quiet_cmd_busybox__ ?= LINK $@ /> cmd_busybox__ ?= $(srctree)/scripts/trylink $(CC) $(LDFLAGS) \ -o $@ \ - -Wl,--warn-common -Wl,--sort-common -Wl,--gc-sections \ + -Wl,--warn-common -Wl,--sort-common \ -Wl,--start-group $(busybox-all) -Wl,--end-group # Generate System.map Index: busybox/applets/applets.c =================================================================== --- busybox.orig/applets/applets.c 2007-02-15 16:43:00.000000000 +0100 +++ busybox/applets/applets.c 2007-02-15 16:43:07.000000000 +0100 @@ -15,16 +15,6 @@ #include "busybox.h" #include <assert.h> -/* Apparently uclibc defines __GLIBC__ (compat trick?). Oh well. */ -#if ENABLE_STATIC && defined(__GLIBC__) && !defined(__UCLIBC__) -#warning Static linking against glibc produces buggy executables -#warning (glibc does not cope well with ld --gc-sections). -#warning See sources.redhat.com/bugzilla/show_bug.cgi?id=3400 -#warning Note that glibc is unsuitable for static linking anyway. -#warning If you still want to do it, remove -Wl,--gc-sections -#warning from top-level Makefile and remove this warning. -#endif - #if ENABLE_SHOW_USAGE && !ENABLE_FEATURE_COMPRESS_USAGE static const char usage_messages[] = #define MAKE_USAGE a non static build work (as mentionned), only static build fails, I'll redo the tcpdump thing when I can (and I will try the svn version as well)

(0002182) goutnet 02-19-07 08:13	I just checked the svn version, and this fix the issue ... I didn't look carefully to the code, but it sounds like there were only minor changes ... Well, anyway, thanks for the trick :)

Issue History
Date Modified	Username	Field	Change
02-16-07 07:47	goutnet	New Issue
02-16-07 07:47	goutnet	Status	new => assigned
02-16-07 07:47	goutnet	Assigned To	=> BusyBox
02-16-07 07:47	goutnet	File Added: .config
02-17-07 08:10	vda	Note Added: 0002177
02-19-07 07:46	goutnet	Note Added: 0002181
02-19-07 08:13	goutnet	Note Added: 0002182
03-02-07 15:09	vda	Status	assigned => closed
03-02-07 15:09	vda	Resolution	open => fixed

Relationships