0001193: stty exit with error when restore state from stty-readable form

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001193

[BusyBox] Other

major

always

02-03-07 19:23

02-04-07 03:14

Reporter

regunkov

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.4.x

Summary

0001193: stty exit with error when restore state from stty-readable form

Description

root@nsg /root # /tmp/busybox stty `stty -g`
stty: 700:3:4b0d:18f:3:1c:7f:15:4:1:a:0:0:0:17:12:1a:11:13:16:15:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0 requires an argument
root@nsg /root # echo $?
1

Additional Information

I'm create fix for version 1.4.1. Inspect this, may be i'm wrong.
Sorry for my english.

regunkov@roman /home/nsg/tmp/busybox $ cat busybox-1.4.1-stty_regunkov.patch
--- busybox-1.4.1/coreutils/stty.c 2007-01-25 00:34:43.000000000 +0300
+++ busybox-1.4.1-regunkov_fixes/coreutils/stty.c 2007-02-04 05:31:39.000000000 +0300
@@ -568,7 +568,10 @@
                NULL
        };
        int i = index_in_str_array(params, name);
- if (i) {
+ if (i<0) {
+ return 0;
+ }
+ else {
                if (!(i == 4 || i == 5))
                        i |= 0x80;
        }

Attached Files

Relationships

Notes
(0002093) bernhardf 02-04-07 03:14	Fixed in r17757. Thanks for the report.

Issue History
Date Modified	Username	Field	Change
02-03-07 19:23	regunkov	New Issue
02-03-07 19:23	regunkov	Status	new => assigned
02-03-07 19:23	regunkov	Assigned To	=> BusyBox
02-04-07 03:14	bernhardf	Status	assigned => closed
02-04-07 03:14	bernhardf	Note Added: 0002093
02-04-07 03:14	bernhardf	Resolution	open => fixed
02-04-07 03:14	bernhardf	Fixed in Version	=> svn