BusyBox Bug and Patch Tracking
BusyBox
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0001176 [BusyBox] Networking Support major always 01-25-07 17:36 01-25-07 23:01
Reporter rockeychu View Status public  
Assigned To BusyBox
Priority normal Resolution fixed  
Status closed   Product Version svn
Summary 0001176: Patches for undefined function of host_and_af2sockaddr without ENABLE_FEATURE_IPV6
Description ping.c & arping need function host_and_af2sockaddr, even without ENABLE_FEATURE_IPV6.

Patches as following:

Index: include/libbb.h
===================================================================
--- include/libbb.h (revision 17534)
+++ include/libbb.h (working copy)
@@ -316,10 +316,8 @@
  * (depending on host), but in theory nothing prevents e.g.
  * UNIX socket address being returned, IPX sockaddr etc... */
 len_and_sockaddr* host2sockaddr(const char *host, int port);
-#if ENABLE_FEATURE_IPV6
 /* Same, useful if you want to force family (e.g. IPv6) */
 len_and_sockaddr* host_and_af2sockaddr(const char *host, int port, sa_family_t af);
-#endif
 /* Assign sin[6]_port member if the socket is of corresponding type,
  * otherwise no-op. Useful for ftp.
  * NB: does NOT do htons() internally, just direct assignment. */

Index: libbb/xconnect.c
===================================================================
--- libbb/xconnect.c (revision 17534)
+++ libbb/xconnect.c (working copy)
@@ -173,12 +173,10 @@
 #define str2sockaddr(host, port, af, ai_flags) str2sockaddr(host, port, ai_flags)
 #endif

-#if ENABLE_FEATURE_IPV6
 len_and_sockaddr* host_and_af2sockaddr(const char *host, int port, sa_family_t af)
 {
        return str2sockaddr(host, port, af, 0);
 }
-#endif

 len_and_sockaddr* host2sockaddr(const char *host, int port)
 {
Additional Information
Attached Files

- Relationships

- Notes
(0002050)
vda
01-25-07 23:01

fixed in rev 17535, thanks.
 

- Issue History
Date Modified Username Field Change
01-25-07 17:36 rockeychu New Issue
01-25-07 17:36 rockeychu Status new => assigned
01-25-07 17:36 rockeychu Assigned To  => BusyBox
01-25-07 23:01 vda Status assigned => closed
01-25-07 23:01 vda Note Added: 0002050
01-25-07 23:01 vda Resolution open => fixed


Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker