BusyBox Bug and Patch Tracking
BusyBox
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0001154 [BusyBox] Other crash always 01-10-07 07:12 01-25-07 22:41
Reporter rockeychu View Status public  
Assigned To BusyBox
Priority normal Resolution fixed  
Status closed   Product Version svn
Summary 0001154: 3 files' patches: networking/libiproute/libnetlink.h, sysklogd/syslogd.c, libbb/xconnect.c
Description Without these patches, I can't build busybox.
 
Index: networking/libiproute/libnetlink.h
===================================================================
--- networking/libiproute/libnetlink.h (revision 17224)
+++ networking/libiproute/libnetlink.h (working copy)
@@ -2,6 +2,7 @@
 #ifndef __LIBNETLINK_H__
 #define __LIBNETLINK_H__ 1

+#include <linux/types.h>
 #include <linux/netlink.h>
 #include <linux/rtnetlink.h>

Index: sysklogd/syslogd.c
===================================================================
--- sysklogd/syslogd.c (revision 17224)
+++ sysklogd/syslogd.c (working copy)
@@ -573,7 +573,7 @@
                }
                /* FIXME: looks ip4-specific. need to do better */
                bb_lookup_host(&remoteAddr, opt_R);
- remoteAddr.sin_port = bb_lookup_port(port, "udp", port);
+ remoteAddr.sin_port = htons(port);//bb_lookup_port(port, "udp", port);
        }
        //if (option_mask32 & OPT_locallog) // -L
 #endif

Index: libbb/xconnect.c
===================================================================
--- libbb/xconnect.c (revision 17224)
+++ libbb/xconnect.c (working copy)
@@ -143,7 +143,7 @@
        /* Needed. Or else we will get each address thrice (or more)
         * for each possible socket type (tcp,udp,raw...): */
        hint.ai_socktype = SOCK_STREAM;
- hint.ai_flags = ai_flags | AI_NUMERICSERV;
+ hint.ai_flags = ai_flags | AI_NUMERICHOST;
        rc = getaddrinfo(host, cp, &hint, &result);
        if (rc || !result)
                bb_error_msg_and_die("bad address '%s'", org_host);
Additional Information
Attached Files

- Relationships

- Notes
(0002048)
bernhardf
01-25-07 16:07

I think this is fixed by now (revision >= 17528). Please confirm.
 
(0002049)
rockeychu
01-25-07 17:30

Yes, it's fixed now. Please close this issue.
 

- Issue History
Date Modified Username Field Change
01-10-07 07:12 rockeychu New Issue
01-10-07 07:12 rockeychu Status new => assigned
01-10-07 07:12 rockeychu Assigned To  => BusyBox
01-25-07 16:07 bernhardf Note Added: 0002048
01-25-07 17:30 rockeychu Note Added: 0002049
01-25-07 22:41 vda Status assigned => closed
01-25-07 22:41 vda Resolution open => fixed


Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker