| Anonymous | Login | Signup for a new account | 11-10-2008 11:09 PST |
| Main | My View | View Issues | Change Log | Docs |
| Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||||
| ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||
| 0001143 | [BusyBox] Documentation | feature | always | 01-05-07 01:42 | 02-18-08 13:09 | ||||
| Reporter | eburghar | View Status | public | ||||||
| Assigned To | BusyBox | ||||||||
| Priority | normal | Resolution | fixed | ||||||
| Status | closed | Product Version | 1.2.x | ||||||
| Summary | 0001143: [patch] support for mount LABEL=xxx and | ||||||||
| Description |
This a backport from nash to support a LABEL=xxx option to mount filesystem without knowing in which device it is located (boot from a usb key for example). The list of filesystems and raid recognized is pretty long but all is enterely configurable in the spirit of busybox. Regards |
||||||||
| Additional Information | |||||||||
| Attached Files |
 busybox-1.2.2-mountlabel.patch [^] (243,521 bytes) 01-05-07 01:42 busybox-1.4.1-mountlabel.patch [^] (206,276 bytes) 03-22-07 10:46 5.patch [^] (144,508 bytes) 02-18-08 12:59 |
||||||||
|
|
|||||||||
 Relationships |
|
|
Notes |
|
|
(0002270) jkolb 03-22-07 10:46 |
Patch updated to apply against 1.4.1 |
|
(0005074) vda 02-18-08 12:11 |
uuidcache_init_partitions(void) { static char ptname[100]; <=== no way you can have such static in bbox ... +char * get_spec_by_uuid(const char *uuid, int * major, int * minor); +char * get_spec_by_volume_label(const char *volumelabel, int * major, int * minor); +int display_uuid_cache(void); These functions are unused. util-linux/volume_id/*.h - why do you need one *.h file per declaration? Feel masochistic today? + procpt = fopen(PROC_PARTITIONS, "r"); + if (!procpt) { + static int warn = 0; + if (!warn++) + fprintf (stderr, _("mount: could not open %s, so UUID and LABEL " + "conversion cannot be done.\n"), + PROC_PARTITIONS); + return; + } Good Lord. Just use xfopen. If /proc/partitions won't open, something is teeribly wrong anyway, what's the point in trying to continue? + static unsigned int sectors[] = { + 63, 255, 256, 16, 399, 0 + }; "const" is missing. +struct hfs_mdb { ... +} __attribute__((__packed__)) *hfs; Please. Do not use global variables unless you have to. + printf("-"); bb_putchar? + strcpy(id->type_version, "1"); Can you store two bytes without function call? Not needed: util-linux/volume_id/Makefile And so on and so forth... |
|
(0005084) vda 02-18-08 13:09 |
Applied with name, many fixes in rev. 21054. |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 01-05-07 01:42 | eburghar | New Issue | |
| 01-05-07 01:42 | eburghar | Status | new => assigned |
| 01-05-07 01:42 | eburghar | Assigned To | => BusyBox |
| 01-05-07 01:42 | eburghar | File Added: busybox-1.2.2-mountlabel.patch | |
| 01-05-07 01:43 | eburghar | Issue Monitored: eburghar | |
| 03-22-07 10:46 | jkolb | File Added: busybox-1.4.1-mountlabel.patch | |
| 03-22-07 10:46 | jkolb | Note Added: 0002270 | |
| 02-18-08 12:11 | vda | Note Added: 0005074 | |
| 02-18-08 12:59 | vda | File Added: 5.patch | |
| 02-18-08 13:09 | vda | Status | assigned => closed |
| 02-18-08 13:09 | vda | Note Added: 0005084 | |
| 02-18-08 13:09 | vda | Resolution | open => fixed |
| Copyright © 2000 - 2006 Mantis Group |  |
