BusyBox Bug and Patch Tracking
BusyBox
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0001097 [buildroot] Other trivial always 11-20-06 17:47 02-12-07 05:43
Reporter alchemar View Status public  
Assigned To buildroot
Priority normal Resolution fixed  
Status closed   Product Version 0.9.27
Summary 0001097: dependency checks - Debian gcc
Description My Debian Distribution adds a version number in gcc that was creating a warning on the dependency checks. I modified the sed statement so that it will grab the first set of numbers instead of the last by looking for "not a number" [^0-9]* instead of "any" .* character at the start of the pattern.



checked out code from svn on 11-19-2006

buildroot/toolchain/dependencies/dependencies.sh

Line 73


COMPILER_VERSION=$($COMPILER --version 2>&1 | head -n1 | $XSED -e 's/^.* \([0-9\.]\)/\1/g' -e "s/[-\ ].*//g")

COMPILER_VERSION=$($COMPILER --version 2>&1 | head -n1 | $XSED -e 's/^[^0-9]* \([0-9\.]\)/\1/g' -e "s/[-\ ].*//g")
Additional Information Output from gcc --version showing extra numbers:

$ gcc --version
gcc (GCC) 3.3.5 (Debian 1:3.3.5-13)
Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Output from make:

sed works: Ok
GNU make version '3.80': Ok
.//toolchain/dependencies/dependencies.sh: line 81: [: 1:3: integer expression expected
gcc version '1:3.3.5': Ok
which installed: Ok
bison installed: Ok
flex installed: Ok
gettext installed: Ok
Build system dependencies: Ok
Attached Files  dependencies.sh [^] (4,223 bytes) 11-20-06 17:47

- Relationships
duplicate of 0000961closed buildroot compiler version check broken on cygwin 

- Notes
(0001770)
bernhardf
11-22-06 13:16

This is completely harmless. I do not consider fixing this, fwiw.
 
(0001788)
alchemar
11-22-06 15:41

Yes it is minor as far as finished executables, but when you are first trying to compile and the first thing you see is an error in the depedency checks it looks worse than it is. I tracked it down, because it was the logical place to start when the the make exited on "Error 2" shortly after the dependecy checks. What you are doing with this program sounds like a really good thing (would have probably had enough time this weekend to finaly get things to compile correctly so I could find out), but I don't expect something this complex to work out of the box. The less "harmless" errors that display on the screen, the less things to verify when things don't work. I am a little disappointed that you won't even consider fixing it when it involves adding four characters to one line. It took more effort to post the reply stating that it was not worth fixing than it would to fix.

Since posting this error, I have gotten more familar with the bug tracking system, and have found other people that were having problems with this exact problem under other distributions. Just because it is "harmless" by the programs standard, doesn't mean that there is not a cost of time and effort involved that could have been used helping to track down more substantial reasons for failures.

It is your project to manage how you see fit. I am sorry that I wasted your time and server resources by posting the fix to something so insignificant, I just hope that it might help the people that don't know it is harmless find out easier than I did.
 
(0001789)
bernhardf
11-22-06 16:14

I've closed and/or fixed about 10, 20 bugs in buildroot this evening.
The thing is that first, i would need to see if your proposed version stripping does work with the simples sed from busybox and second that i have to be absolutely sure that we don't produce *wrong* version strings from the HOSTCC.

If you can check that the most simple sed configuration from busybox-1.0.0 without any features sanitizes your versionstring in an expected way, then please let me know.

Apart from that, i'm not the only one who fixes bugs or checks stuff into buildroot, and no, it's also not my project. But as said, if you can check against busybox-1.0.0 and all behaves properly, then we'll apply the patch.

TIA
 
(0001820)
bernhardf
11-28-06 01:48

With your proposed patch, i get:

$ gcc-4.2-HEAD --version 2>&1 | head -n 1
gcc-4.2-HEAD (GCC) 4.3.0 20061024 (experimental)
$ gcc-4.2-HEAD --version 2>&1 | head -n 1 | sed -e 's/^[^0-9]* \([0-9\.]\)/\1/g' -e "s/[-\ ].*//g"
gcc

which is not acceptable.

From the looks, this should work also for you and should be generic enough to please anybody else:

-e 's/^.*(.CC) \([0-9\.]\)/\1/g' -e "s/[-\ ].*//g"

What do you think?
 
(0001824)
bernhardf
11-28-06 02:08

fixed in r16703
 

- Issue History
Date Modified Username Field Change
11-20-06 17:47 alchemar New Issue
11-20-06 17:47 alchemar Status new => assigned
11-20-06 17:47 alchemar Assigned To  => uClibc
11-20-06 17:47 alchemar File Added: dependencies.sh
11-22-06 13:16 bernhardf Note Added: 0001770
11-22-06 15:41 alchemar Note Added: 0001788
11-22-06 16:14 bernhardf Note Added: 0001789
11-28-06 01:48 bernhardf Note Added: 0001820
11-28-06 02:07 bernhardf Relationship added duplicate of 0000961
11-28-06 02:08 bernhardf Status assigned => closed
11-28-06 02:08 bernhardf Note Added: 0001824
11-28-06 02:08 bernhardf Resolution open => fixed
02-12-07 05:43 vapier Status closed => assigned
02-12-07 05:43 vapier Assigned To uClibc => buildroot


Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker